Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CWE-235
Fixed Http Parameter Pollution Rule at :
(1) Encoded URI path parameter /v1/taskInfo/{taskId} with UTF_8 encoding : presto-main/src/main/java/com/facebook/presto/resourcemanager/DistributedTaskInfoResource.java:72
(2) presto-main/src/main/java/com/facebook/presto/server/protocol/QueryResourceUtil.java
Motivation and Context
Concatenating untrusted input into path, query string, or parameters for HTTP message (in the URL or in the request body) may allow an attacker to override/add unexpected request parameters. Attacker may change the intended HTTP request semantics, and may give him/her access to unauthorized data or bypass web application firewall validations.
Impact
No Impact
Test Plan
Verified existing Unit test case for above fix :
(1) presto-tests/src/test/java/com/facebook/presto/resourcemanager/TestDistributedTaskInfoResource.java
(2) presto-tests/src/test/java/com/facebook/presto/server/TestQueryResource.java
Release Notes
Please follow release notes guidelines and fill in the release notes below.