-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presto SQL Parser Now Supports Trailing Commas #23928
Open
chbhat10
wants to merge
8
commits into
prestodb:master
Choose a base branch
from
chbhat10:trailing-comma
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chbhat10
requested review from
steveburnett,
elharo and
a team
as code owners
October 31, 2024 18:18
Codenotify: Notifying subscribers in CODENOTIFY files for diff fcac3b4...d5c54a4.
|
steveburnett
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, reviewed all pages in the local doc build. Thanks for the doc!
4 tasks
Hi, @tdcmeehan and/or @elharo does this issue and PR fall within your purview? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for "trailing commas" in the SQL parser for Presto. This change allows users to include a trailing comma in their SELECT statements, aligning with the style supported by other SQL engines.
Motivation and Context
The change is motivated by two main reasons:
This change addresses the issue "Support Google-style trailing comma in SELECT Support Google-style trailing comma in SELECT #23569". Allowing trailing commas is a minor deviation from ANSI SQL, but it aligns with the style adopted by many programming languages like Python, Rust, and TypeScript, which enhances usability and reduces syntax errors.
Impact
This change introduces a new feature in the SQL parser, allowing trailing commas in SELECT statements. It does not affect existing functionality and is backward compatible.
Test Plan
The change has been tested by adding unit tests that cover various scenarios involving trailing commas in SELECT statements. These tests ensure that the parser correctly handles the new syntax without introducing regressions.
Contributor checklist