Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 0.290 #23936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaystarshot
Copy link
Member

@jaystarshot jaystarshot commented Nov 1, 2024

Fixes #23945

Missing Release Notes

Andrii Rosa

Bikramjeet Vig

Chen Yang

Jialiang Tan

Jimmy Lu

Joe Abraham

Naveen Nitturu

Pratik Joseph Dabre

Reetika Agrawal

Richard Barnes

abhibongale

ajay-kharat

lithinpurushothaman

namya28

Extracted Release Notes

All Commits

  • c16711a Handle empty tables with no mappings (Karnati-Naga-Vivek)
  • 7805ba5 Revert "Upgrade avro & its dependencies to resolve CVEs" (Konjac Huang)
  • 9e0c295 Fix localexchange propertie when spill is enabled (Feilong Liu)
  • be973cc Fix formatting in presto_cpp/properties.rst (Steve Burnett)
  • c3abe54 Add Comments in PRs to CONTRIBUTING.md (Steve Burnett)
  • f02bf22 [native] Allow new Velox GCS changes (Deepak Majeti)
  • 68aea2f [native] Fix table writer to use the actual storage format (Ke)
  • 8f630f9 Update HiveWriterFactory to use actualStorageFormat (Ke)
  • 4391c9b [native] Advance velox. (Amit Dutta)
  • fcac3b4 [native] Use new metrics() API in PrestoExchangeSource (lingbin)
  • 600b7bc [native] Add Linux Memory Manager (mohsaka)
  • 636a663 [native] Advance velox. (Amit Dutta)
  • d3051d6 Fix array_intersect for array<array> (Ke)
  • 0d04e97 Fix depenedency version issue (Konjac Huang)
  • 09977dc Add native_writer_spill_enabled session doc back (Jialiang Tan)
  • 2834ecc Add native_max_local_exchange_partition_count session property (Andrii Rosa)
  • a4fe924 Propagate underlying exception in NativeSystemSessionPropertyProvider (Andrii Rosa)
  • b1ab1e4 Unblock TestPrestoNativeHiveExternalTableTpchQueriesParquet (Andrii Rosa)
  • afccfed Advance Velox (Andrii Rosa)
  • 4d0df87 [native] Add session property native_writer_flush_threshold_bytes (Jialiang Tan)
  • dd638db [native] Fix typos in ProtocolToThrift README (Zuyu ZHANG)
  • 38ca2ec [native] Propagate table writer concurrency settings (Andrii Rosa)
  • 189e817 [native] Remove native session native_join_spill_partition_bits (Jialiang Tan)
  • 1c0fc17 Upgrade avro & its dependencies to resolve CVEs (Hazmi)
  • 5ed9da1 Add OpenAPI documentation for /v1/properties/session (Pratik Joseph Dabre)
  • 2b9e483 [native] Add e2e native session property provider tests with sidecar (Pratik Joseph Dabre)
  • 4f7fad7 Integrate session property plugin with sidecar (Pratik Joseph Dabre)
  • ebbfdac Integrate session property SPI with Presto engine (Pratik Joseph Dabre)
  • 524fbea Introduce session properties SPI (Pratik Joseph Dabre)
  • cee51f5 Separate out worker session properties and introduce JavaFeaturesConfig (Pratik Joseph Dabre)
  • b936b6d Allow workers to act as coordinator sidecars (Pratik Joseph Dabre)
  • 1640594 [native] Use core protocol header in FunctionMetadata (Abhisek Saikia)
  • 8abe0c9 [native] split protocol header (Abhisek Saikia)
  • d384cca Add admin/properties-session.rst (Steve Burnett)
  • fe3b959 Add documentation for properties (Timothy Meehan)
  • 52cdfff Automatically link sections in rst (Tim Meehan)
  • 88a35db Add scope for OAUTH2 authentication in Iceberg's REST catalog (Denodo Research Labs)
  • 0ef5f82 [native] Symlink table mapping for Delta table access. (Reetika Agrawal)
  • c8a90e5 Allow InternalPlanNodes to accept a PlanVisitor (Rebecca Schlussel)
  • 758205a Upgraded commons-io (Hazmi)
  • 855ac73 Added gson to dependency management in bigquery (Hazmi)
  • ed9e225 Upgraded protobuf-java dependencies to 3.25.5 (Hazmi)
  • b324cf0 Fix error in sql/update.rst (Steve Burnett)
  • c2dad16 [native]Update TaskManagerTest to create new file in local file sink (Xiaoxuan Meng)
  • 6537485 [native] Add a metric to track expected reduction of memory and minor fixes (Bikramjeet Vig)
  • 96b716d [native] Update gtest targets for presto_function_metadata_test (zuyu)
  • e1c2db8 Rename enabledOptimizedReader -> enableBatchReader (Zac Blanco)
  • 6909c85 [iceberg] Add UUID type support (Zac Blanco)
  • 342ceb0 [parquet] Add a profile to re-generate batch readers (Zac Blanco)
  • 1512671 Extend join prefilter optimizer to use hash (Feilong Liu)
  • b0a9144 [native]Advance velox version with flaky test fix (Xiaoxuan Meng)
  • 90fe610 [native] Update metadata for function combinations in FunctionMetadataTest (Pramod)
  • 7e6691d Add sidecars to NodeManager and add PluginNodeManager (Tim Meehan)
  • 38e977e [native] Add partitioned output buffers sessions (Jialiang Tan)
  • bba64ad [native] Retrieve Json function metadata (Pramod)
  • d00cbe8 [native] Update presto_protocol (Pramod)
  • a4e7d3f [native] Advance velox. (Amit Dutta)
  • 0c19d4f Fix native_expression.max_array_size_in_reduce session property (Pratik Joseph Dabre)
  • 47e3730 Add more tests for ArrayNormalizeFunction. (Amit Dutta)
  • 3d62b27 Add presto_cpp/properties-session.rst (Steve Burnett)
  • 8cceea2 [native] Include glog for thrift artifact build (Christian Zentgraf)
  • f73097f Pass extra credentials to system connector (SthuthiGhosh9400)
  • f6c3abe [native] Revert remaining filter pushdown from FilterNode (Jimmy Lu)
  • 85a0fa4 [native] Fix periodic memory checker reporting metrics (Jialiang Tan)
  • 8c69bcb Use JDBC for ContainerQueryRunner (Joe Abraham)
  • 61f5c3e Add "native_expression.max_array_size_in_reduce" session property. (Sergey Pershin)
  • 86ae524 Add documentation for query plan and plan fragment (Steve Burnett)
  • 90742a4 Fix flaky test TestQueues.testEagerPlanValidation (Bryan Cutler)
  • 9f54207 Fix aggregate queries with labels column in prometheus (lukmanulhakkeem)
  • e4c7e05 [native] Advance velox. (Amit Dutta)
  • 87277f8 [native] Add the native isBlockedTiming stat to operator stats (Zuyu ZHANG)
  • f1058cc [Iceberg]Enable test cases for rename table on REST and NESSIE catalog (wangd)
  • 5f3835e [native] Advance Velox version. (Sergey Pershin)
  • d280efc [native] Install all adapter dependencies in dependency dockerfiles (Deepak Majeti)
  • 6efcf0f Centralize dependency versions in parent pom.xml (ajay-kharat)
  • bee3c6e fix the multi-level subgroup issue (Yihong Wang)
  • 27eb666 [native] Add query trace session properties to native session (Jialiang Tan)
  • 3236937 [native] Advance velox. (Amit Dutta)
  • 10227bb [native] Add counter to track effectiveness of memory pushback (Bikramjeet Vig)
  • 4799dd2 Enable verbose runtime stats for connector optimizer (Feilong Liu)
  • 6bf9e3c Replace presto-router/README.txt with README.md (Steve Burnett)
  • fb3a00f [native]Prestissimo exception error code conversion fix (Xiaoxuan Meng)
  • 9c4e018 [prestissimo] Fix memory push back latency unit (Jialiang Tan)
  • b7814df Add SPI to support plugin for custom plan checkers (Bryan Cutler)
  • 4b0ab66 Add property for eager building of plan (Bryan Cutler)
  • 8ce4ccd Update presto-docs/src/main/sphinx/connector/singlestore.rst (oyeliseiev-ua)
  • ac954c2 Update presto-docs/src/main/sphinx/connector/singlestore.rst (oyeliseiev-ua)
  • 44e6604 Update presto-docs/src/main/sphinx/connector/singlestore.rst (oyeliseiev-ua)
  • 01354d6 Update SingleStore docs (oyeliseiev-ua)
  • cbd1a11 Fix round for float value when input out of long range (wangd)
  • 9fa4aee Add cast functions for char datatype to numeric types (Elbin Pallimalil)
  • 48f0a0c [native] Update velox (Christian Zentgraf)
  • 7deadd1 Upgrade the logback-core version to 1.2.13 (namya28)
  • f9f884d [native] Add support for DEPENDENCY_DIR, INSTALL_PREFIX, PYTHON_VENV (Deepak Majeti)
  • 96c58c9 [CLI] Add flag to disable certificate verification (Zac Blanco)
  • 64be0e3 Add trace session properties to presto native (Jialiang Tan)
  • 1192632 Read dataDirectory from system/env variables (pratyakshsharma)
  • 66f34de [native] Advance velox. (Amit Dutta)
  • 6d096e5 [native] Minor refactor of PeriodicMemoryChecker (Bikramjeet Vig)
  • 152e64d Turn on optimized_scale_writer_producer_buffer by default (jaystarshot)
  • 6f60355 Fix the length of offsets array in parquet long decimal value decoders (wangd)
  • 88c03ab Fix distinct operator for UUID (abhibongale)
  • 832b071 [native] Advance velox. (Amit Dutta)
  • 7c814ae Don't generate code for Parquet readers; Make batchreader code available and findable in the source repository (Elliotte Rusty Harold)
  • 751768a Fix some toString methods in presto-orc (Fix some toString methods in presto-orc #23750) (Serge Druzkin)
  • 64b5ebf Fix REST session bug for Iceberg REST catalogs (kiersten-stokes)
  • 1a8c27d Fix formatting problem. (Krishna Pai)
  • ceeab87 Register dwrf reader/writer factories. (Krishna Pai)
  • 8bd65b0 Disable streaming aggregations. (Krishna Pai)
  • 8c26459 Expand block documentation (Elliotte Rusty Harold)
  • 8a026e5 Remove array_dupes and array_has_dupes alias. (Amit Dutta)
  • 699a808 [presto-orc] Fix row index position when compression is disabled (Serge Druzkin)
  • 176e886 [native] Push down FilterNode into TableScan (Jimmy Lu)
  • c4c02f8 [native]Remove bucket property set in table write node (Xiaoxuan Meng)
  • af88522 [native] Advance velox. (Amit Dutta)
  • 266ccec Add Iceberg REST auth server configuration property (kiersten-stokes)
  • 83cb0f6 Fix typo in TupleDomainFilterUtils (Rebecca Schlussel)
  • 24a488b Allow task writer counts to be non-power of two for native engine (Xiaoxuan Meng)
  • bd07a0e Remove use of deprecated getTypeLength method (Elliotte Rusty Harold)
  • 9e2ed29 [native] Advance velox. (Amit Dutta)
  • 489acf6 Add doc requirement for new methods to CONTRIBUTING.md (Steve Burnett)
  • ffb7643 orc_output_buffer_chunk_size (Chen Yang)
  • 092ba79 Add a PR link in release-0.282.rst (Steve Burnett)
  • 8385163 Add QueryType to AccessControlContext (Rohan Pal Sidhu)
  • 375dd5a Add TLS support for Prometheus connector (Ananthu-Nair)
  • a8c1ee3 Add doc for driver.cancel-tasks-with-stuck-operators-threshold-ms (Steve Burnett)
  • 6c57a3e [Iceberg]Support timestamp without timezone in time travel expressions (wangd)
  • 27d38bf Remove format() calls for constant strings with no arguments (Elliotte Rusty Harold)
  • 4bdd580 Delete unused code (Elliotte Rusty Harold)
  • 2c57ef3 [native]Add to set bucket property flag in table write plan node (Xiaoxuan Meng)
  • 12afd26 [native] Remove memory transfer capacity (Jialiang Tan)
  • 2242d6c Upgrade Postgres JDBC Driver to 42.6.1 (Ajay Kharat)
  • a93eafc [native] Advance velox. (Amit Dutta)
  • 62ca080 Apply suggestions from code review (Jimmy Lu)
  • 6f4d3cc [native] Add native_selective_nimble_reader_enabled session property (Jimmy Lu)
  • 9bbfbaf [native] Add native e2e tests for unicode in JSON (Ge Gao)
  • 7d9a0b0 Remove redundant check for short decimal type in parquet decoders (wangd)
  • 98ff012 Avoid confusion between ErrorCode and ErrorCodeSupplier (Elliotte Rusty Harold)
  • 2f4ea64 Use semantic asserts (Elliotte Rusty Harold)
  • 87e2beb Remove test-jar dependency (Elliotte Rusty Harold)
  • 649b45a Fix formatting in functions/json.rst (Steve Burnett)
  • 30d6a8d [native] Advance velox. (Amit Dutta)
  • 8b6b9db Update sqlserver docker image version (Reetika Agrawal)
  • 95d2439 Fix EffectivePredicateExtractor (Anant Aneja)
  • 33ff952 initial commit for ip_prefix_subnets (Matt Calder)
  • 79a5802 [native] Remove dependencies of old arbitrator config (Jialiang Tan)
  • 1a4339e Fix case to map optimization (Tim Meehan)
  • bf5928e Add presto-server to maven-checks (Timothy Meehan)
  • 52081ac Add missing article (Elliotte Rusty Harold)
  • 2409481 [native] Advance velox. (Amit Dutta)
  • c00f8af Use Provisio plugin for packaging (Tim Meehan)
  • 46eacc3 [native] Removing status message from native worker to support http/2 (Amit Dutta)
  • 0b10149 Acknowledge results in HEAD request to output buffer (Tim Meehan)
  • 26fd8db broadcasted --> broadcast (Elliotte Rusty Harold)
  • ba811b9 [native] Fix recording of SUM type in PrometheusStatsReporter (lingbin)
  • fd2615e Add support for AuthorizedIdentity JWT claim (prithvip)
  • bcb2431 Move JWT Authentication from airlift to presto (prithvip)
  • d7c6d4e Move impersonation authorization to SessionSupplier (prithvip)
  • 5a6542c [native] Update Presto Protocol for Iceberg Writes (Jalpreet Singh Nanda (:imjalpreet))
  • f21f15e [iceberg] Make com.facebook.presto.iceberg.PrestoIcebergSchema.aliases not null (Jalpreet Singh Nanda (:imjalpreet))
  • cefb7ab [native] Advance velox. (Amit Dutta)
  • 9c22929 [native] Reduce stuck drivers threashold to detach worker. (Sergey Pershin)
  • 7c0f20b [Iceberg]Ensure concurrently executed tests use different table names (wangd)
  • 64d1a66 handle null pages when filling in row IDs (Elliotte Rusty Harold)
  • 626bb99 [Native] Add HiveConnectorFactory registration to tests (Deepak Majeti)
  • d7a9118 [native] Remove unused includes. (Amit Dutta)
  • b09edc1 [native] Advance velox. (Amit Dutta)
  • 7c2993f Fix nullability of columns in information schema (Naveen Nitturu)
  • a85138e Enable set_table_property procedure for Iceberg (Reetika Agrawal)
  • 030e120 [native] Add ability to cancel Tasks with stuck Drivers. (Sergey Pershin)
  • d849304 [native] Update presto protocol (Jalpreet Singh Nanda (:imjalpreet))
  • f834af0 [native] Add Velox query config selective_nimble_reader_enabled (Jimmy Lu)
  • 1ab2cbc [native] Advance velox. (Jimmy Lu)
  • 251fe6f Modify CREATE TABLE sql in iceberg tests (Reetika Agrawal)
  • 4bedf5e [native] Make periodic cache flush incremental (Zac Wen)
  • 7b68207 Standardize on Guava for VisibleForTesting annotation (Elliotte Rusty Harold)
  • 7727df8 [native] Advance velox. (Amit Dutta)
  • 1167b1e fix formatting in presto-cpp/features.rst (Steve Burnett)
  • 3b36ffe Update asm.version to fix upper bound dependencies error (aditi-pandit)
  • ac510c2 [native] Add session properties for expression evaluation optimizations (Bikramjeet Vig)
  • e4b8abb Persist logical type parameters in parquet files (auden-woolfson)
  • d020f10 [native] Advance velox (Bikramjeet Vig)
  • 84bd201 [Iceberg] Clean up unclosed resources from library (Zac Blanco)
  • 52c090e [parquet] Support 64-bit RLE-encoded ShortDecimal (Zac Blanco)
  • 97d88cf Make TaskUpdate size exceeded message succinct (misterjpapa)
  • 0902cb3 Add support for microsecond precision Time type (Zac Blanco)
  • 1a2228d Fix Iceberg procedures to uniformly support named arguments (wangd)
  • ca6a978 [Doc]Supplement explanations on named and positional arguments in CALL (wangd)
  • 73fd8c2 initial commit for is_private_ip (Matt Calder)
  • 9d46340 Add SimplePlanFragment to the SPI (Rebecca Schlussel)
  • 07bf13a [Iceberg] Add statistics file caching (Zac Blanco)
  • 68bac89 Fix textfile ambiguous timestamps and different storage timezones (Rebecca Schlussel)
  • 1f74d4d Fix interpreting like expressions with escape (Rebecca Schlussel)
  • 8e3710b [native] Advance velox. (Amit Dutta)
  • 0c394bf Fix type signature with whitespace in parameters (Tim Meehan)
  • 8964fed Support procedure fast_forward for iceberg (Reetika Agrawal)
  • e789025 Add presto icon to .idea (auden-woolfson)
  • b7f0bf1 Fix formatting in functions/array.rst (Steve Burnett)
  • f393c60 Remove using namespace from header files (Remove using namespace from header files #23575) (Richard Barnes)
  • a0e9758 Support procedure set_current_snapshot for Iceberg (Reetika Agrawal)
  • 8f8f690 Terminate all Velox macro calls with semicolon (David Tolnay)
  • 5b10fba Fix join validation when spill enabled for native (Rebecca Schlussel)
  • 5b78cc8 Making configuration manager loaded boolean flag Atomic (Swapnil Tailor)
  • 6f28f37 Prepare function guidelines (Elliotte Rusty Harold)
  • 62d2641 Fix formatting of code example for array_has_duplicates (Steve Burnett)
  • eb7ef88 SSL enablement for Cassandra connector (lithinpurushothaman)
  • 7b14c7a Fix Server Active State Endpoint (Swapnil Tailor)
  • c778704 [native] fix openssl not found on Ubuntu (Christian Zentgraf)
  • 92b27b6 Add ParquetQuickStatsBuilder bean exporter (Anant Aneja)
  • a0d25e2 Clarify top N array function (Elliotte Rusty Harold)
  • fce4ddf [native] Fix cmake target name (lingbin)
  • 22b6b09 make IcebergDistributedSmokeTestBase abstract (auden-woolfson)
  • 7bb59d3 [iceberg] Add procedure rollback_to_timestamp (Jalpreet Singh Nanda (:imjalpreet))
  • ffd30da Add support to query Iceberg table by branch/tag name (Reetika Agrawal)
  • 4974aeb Add VARCHAR support with SYSTEM_VERSION AS OF (Reetika Agrawal)
  • c408975 Adding alter support for mongodb (Naveen Nitturu)
  • 87db58c Fix CODEOWNERS (wangd)
  • 721d71f Remove unneeded local variable (Elliotte Rusty Harold)
  • c4dbb21 [iceberg] Rename table to table_name and update docs with correct argument names (Jalpreet Singh Nanda (:imjalpreet))
  • 848b373 [native] Advance velox. (Amit Dutta)
  • b1f849e [native] Remove unnecessary semicolons (lingbin)
  • 2bceaa0 Avoid retrying once a FileNotFoundException is thrown (Deepa-George)
  • 1eafe7d Revert "[native] Fill protocol::TaskStats::completedDrivers with finished splits" (Zac Wen)
  • cac6682 Split functions configuration from FeaturesConfig (Tim Meehan)
  • cd2fb54 Add more code owners for Iceberg document (wangd)
  • 175f177 Make legacy_json_cast hidden (Timothy Meehan)
  • 4dd678d Fix NPE when pruning info from query plan (Zac Blanco)
  • d6a42fc Remove unused usages of SqlParser, TypeProvider, VariableAllocator (Rebecca Schlussel)
  • 539a448 Evaluate project node on values node (jackychen718)
  • 838293c Add doc for field_names_in_json_cast_enabled (Steve Burnett)
  • b24ddb1 Fix DeleteNode does not have a Graphviz visitor (Zac Blanco)
  • d16bf86 [Iceberg] Use remainingPredicate in filter stats calc (Zac Blanco)
  • 72c07cc Accept query id and slug in QueuedStatement (prithvip)
  • c111f79 [native] Advance velox. (Amit Dutta)
  • c66fa35 Add Iceberg table property to set the max columns number for which metrics are collected (wangd)
  • 3544e0e [Iceberg]Support identifying max columns number on metrics collection (wangd)
  • 8b5c969 Remove unused fields (Elliotte Rusty Harold)
  • 7fde59b Add session property for partial aggregation and spill (Ke)
  • bc2f280 Use isLeaf to figure out if plan fragment is a leaf stage (Nikhil Collooru)
  • 940d2d8 Fix Iceberg document (Reetika Agrawal)
  • 225b206 Add Iceberg metadata table $refs (Reetika Agrawal)
  • 030f25f [native] Remove sanity check for event base from idle session in GCC (Deepak Majeti)
  • 8af5d11 [native] Update readme (Christian Zentgraf)
  • 7b04566 Drop test tables to make CTE and other native tests run correctly (Mahadevuni Naveen Kumar)
  • d270495 Fix querying and filtering using Iceberg metadata columns (Mahadevuni Naveen Kumar)
  • 581eb87 Extend MongoDB connector support binData (exxiang)
  • 428cee2 [native] Fix conversion of partitining const keys. (Sergey Pershin)
  • 410d3ec Update version of maven-gpg-plugin (Linsong Wang)
  • 6c4ee55 [native] Advance velox. (Amit Dutta)
  • 961ff8a [Iceberg]Refactor test classes to avoid them growing too large (wangd)
  • d6f8588 Skip exception type check for dwrf reader internal check change (xiaoxmeng)
  • 6b54b7d Validate all like patterns can only use one character escape strings (auden-woolfson)
  • 6634b7a Distinguish scheduler runtime stats for scan stage (Nikhil Collooru)
  • ab162e7 [native] Fix a typo in LocalPersistentShuffleReader ctor. (Zuyu ZHANG)
  • d7ca7af [native] Switch to use string based arbitrator configs (Jialiang Tan)
  • febecd6 [native] Advance velox. (Amit Dutta)
  • 7d3e06e Use efficient empty string test (Sam Partington)
  • 9ede266 Avoid pushdown of negative position for element_at for array (Jayaprakash Sivaprasad)
  • 64f9455 [native] Advance velox. (Amit Dutta)
  • 63a472b Block ipaddress type in prestissimo (mohsaka)

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered and reviewed only the Extracted Release Notes. I did not examine any of the PRs in the Missing Release Notes section of this doc PR to consider if they need new release note entries written for them and added to the doc in this PR.

  • Edited punctuation throughout so that the text of a release note entry ends with a period (.), followed by the PR link - which is not followed by a period for consistency with the previous recent release notes.

  • Other minor edits, capitalizing Presto, Iceberg, Parquet, and the like.

  • Please note the comments where I ask for a review of my suggested changes.

  • Please review these release notes for the headings following the sequence in the Order of sections of the Release Notes Guidelines, and that the entries within each heading follow the Order of changes, especially after my comments and edits are applied.

presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
______________________________________
* Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`.

Presto Iceberg Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Presto Iceberg Changes

* Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`.

Presto Iceberg Changes
______________________
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
______________________


Presto Iceberg Changes
______________________
* Add test for logical type storage in parquet files :pr:`23388`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest deleting the three lines before this line to remove the Presto Iceberg Changes header, and this line should be moved to the Iceberg Connector Changes section.


Presto Iceberg Changes
______________________
* Add test for logical type storage in parquet files :pr:`23388`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add test for logical type storage in parquet files :pr:`23388`.
* Add test for logical type storage in Parquet files. :pr:`23388`

______________________
* Add test for logical type storage in parquet files :pr:`23388`.

Presto Parquet Changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading does not appear in the Order of sections in the Release Notes Guidelines. I don't think that automatically makes it wrong, but I ask that other reviewers consider if the entry under this heading more properly belongs in General Changes or maybe another section in the Release Notes. If the entry Fix bug so... is moved, delete this Presto Parquet Changes heading.

@jaystarshot
Copy link
Member Author

Thanks @steveburnett for the intial review, I will go through the PR with no release notes to see if there are any more. Because of your enforcement throughout all PRs, this time most PRs have good release notes which I think is great!

@jaystarshot jaystarshot force-pushed the release-notes-0.290 branch 2 times, most recently from 9866f49 to 62c6a41 Compare November 4, 2024 18:17
@jaystarshot
Copy link
Member Author

@steveburnett Extracted release notes from the non release notes PRs. Please review

@jaystarshot jaystarshot force-pushed the release-notes-0.290 branch 2 times, most recently from b00a513 to 9066156 Compare November 4, 2024 20:03
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update with the new entries from the PRs with no release notes! Pulled updated branch, reviewed new local doc build.

Changes in this review:

  • Nits of punctuation and formatting, and a few suggested revisions.

  • Reviewed the the order of the headings as correctly following the sequence in the Order of sections of the Release Notes Guidelines. Thanks for rearranging that!

  • Please note the comments where I ask for a review of my suggested changes.

Not done:

The entries in the sections

  • General Changes
  • Presto C++ (Native Execution) Changes
  • Iceberg Connector Changes

need to be rearranged to follow the Order of changes (Fix, Improve, Add, ...).

presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Pull updated branch, review new doc build. Just a few nits and suggestions left, nothing major.

presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
@jaystarshot jaystarshot force-pushed the release-notes-0.290 branch 2 times, most recently from 929bcc6 to 981f187 Compare November 4, 2024 23:07
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One, I think final, formatting nit that I should have caught earlier. Everything else looks great!

presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Found one more rephrasing (and relocation) suggestion, and a punctuation nit on a second additional start-to-finish review.

presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.290.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the nits in the last review!

Suggested revision for the newly-added entry.

Review of the full 0.290 release notes beginning to end found no other issues to comment on.

* Add incremental periodic cache persistence for Presto C++ worker. :pr:`23626`
* Add native system session property provider. :pr:`23045`
* Remove session property ``native_join_spiller_partition_bits``. :pr:`23906`
* Reverted merging of FilterNode into TableScanNode done in pr `23755`. :pr:`23755`
Copy link
Contributor

@steveburnett steveburnett Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Reverted merging of FilterNode into TableScanNode done in pr `23755`. :pr:`23755`
* Revert merging of ``FilterNode`` into ``TableScanNode`` done in :pr:`23755`. :pr:`23855`

Nit of formatting, fix link to PR 23755, correct end link to PR 23855.

Note: I'll mention that "Revert" is not in the Order of changes in the Release Notes Guidelines, which may mean that we need to add "Revert" to the Order of changes. Also, I think this entry can stay in its list position of last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Release 0.290
2 participants