-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 0.290 #23936
base: master
Are you sure you want to change the base?
Add release notes for 0.290 #23936
Conversation
c44a81e
to
1286905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered and reviewed only the Extracted Release Notes. I did not examine any of the PRs in the Missing Release Notes section of this doc PR to consider if they need new release note entries written for them and added to the doc in this PR.
-
Edited punctuation throughout so that the text of a release note entry ends with a period (.), followed by the PR link - which is not followed by a period for consistency with the previous recent release notes.
-
Other minor edits, capitalizing Presto, Iceberg, Parquet, and the like.
-
Please note the comments where I ask for a review of my suggested changes.
-
Please review these release notes for the headings following the sequence in the Order of sections of the Release Notes Guidelines, and that the entries within each heading follow the Order of changes, especially after my comments and edits are applied.
______________________________________ | ||
* Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`. | ||
|
||
Presto Iceberg Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presto Iceberg Changes |
* Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`. | ||
|
||
Presto Iceberg Changes | ||
______________________ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
______________________ |
|
||
Presto Iceberg Changes | ||
______________________ | ||
* Add test for logical type storage in parquet files :pr:`23388`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest deleting the three lines before this line to remove the Presto Iceberg Changes
header, and this line should be moved to the Iceberg Connector Changes
section.
|
||
Presto Iceberg Changes | ||
______________________ | ||
* Add test for logical type storage in parquet files :pr:`23388`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add test for logical type storage in parquet files :pr:`23388`. | |
* Add test for logical type storage in Parquet files. :pr:`23388` |
______________________ | ||
* Add test for logical type storage in parquet files :pr:`23388`. | ||
|
||
Presto Parquet Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading does not appear in the Order of sections in the Release Notes Guidelines. I don't think that automatically makes it wrong, but I ask that other reviewers consider if the entry under this heading more properly belongs in General Changes or maybe another section in the Release Notes. If the entry Fix bug so... is moved, delete this Presto Parquet Changes heading.
Thanks @steveburnett for the intial review, I will go through the PR with no release notes to see if there are any more. Because of your enforcement throughout all PRs, this time most PRs have good release notes which I think is great! |
9866f49
to
62c6a41
Compare
@steveburnett Extracted release notes from the non release notes PRs. Please review |
b00a513
to
9066156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update with the new entries from the PRs with no release notes! Pulled updated branch, reviewed new local doc build.
Changes in this review:
-
Nits of punctuation and formatting, and a few suggested revisions.
-
Reviewed the the order of the headings as correctly following the sequence in the Order of sections of the Release Notes Guidelines. Thanks for rearranging that!
-
Please note the comments where I ask for a review of my suggested changes.
Not done:
The entries in the sections
- General Changes
- Presto C++ (Native Execution) Changes
- Iceberg Connector Changes
need to be rearranged to follow the Order of changes (Fix, Improve, Add, ...).
4c7106f
to
bc0d700
Compare
d9de61e
to
daeb03e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Pull updated branch, review new doc build. Just a few nits and suggestions left, nothing major.
929bcc6
to
981f187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One, I think final, formatting nit that I should have caught earlier. Everything else looks great!
6209cf3
to
260baa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Found one more rephrasing (and relocation) suggestion, and a punctuation nit on a second additional start-to-finish review.
eeab87c
to
9c4e636
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the nits in the last review!
Suggested revision for the newly-added entry.
Review of the full 0.290 release notes beginning to end found no other issues to comment on.
* Add incremental periodic cache persistence for Presto C++ worker. :pr:`23626` | ||
* Add native system session property provider. :pr:`23045` | ||
* Remove session property ``native_join_spiller_partition_bits``. :pr:`23906` | ||
* Reverted merging of FilterNode into TableScanNode done in pr `23755`. :pr:`23755` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Reverted merging of FilterNode into TableScanNode done in pr `23755`. :pr:`23755` | |
* Revert merging of ``FilterNode`` into ``TableScanNode`` done in :pr:`23755`. :pr:`23855` |
Nit of formatting, fix link to PR 23755, correct end link to PR 23855.
Note: I'll mention that "Revert" is not in the Order of changes in the Release Notes Guidelines, which may mean that we need to add "Revert" to the Order of changes. Also, I think this entry can stay in its list position of last.
Fixes #23945
Missing Release Notes
Andrii Rosa
Bikramjeet Vig
Chen Yang
Jialiang Tan
Jimmy Lu
Joe Abraham
Naveen Nitturu
Pratik Joseph Dabre
Reetika Agrawal
Richard Barnes
using namespace
from header files #23575 Removeusing namespace
from header files (Merged by: Rebecca Schlussel)abhibongale
ajay-kharat
lithinpurushothaman
namya28
Extracted Release Notes
iceberg.max-statistics-file-cache-size
configuration property. :pr:23177
.inline_projections_on_values
and configuration propertyoptimizer.inline-projections-on-values
to evaluate project node on values node :pr:23245
.ALTER TABLE
statement. :pr:23266
.23386
).23388
.23388
.23407
.23456
.metrics_max_inferred_column
to configure the max columns number for which metrics are collected, and supportmetrics_max_inferred_column
for Iceberg table withPARQUET
format :pr:23468
.23472
.23479
.23503
.23510
.is_private_ip
that returns true when the input IP address is private or a reserved IP address ... :pr:23520
.native_max_partial_aggregation_memory
which specifies presto native max partial aggregation memory when data reduction is not optimal :pr:23527
.native_max_extended_partial_aggregation_memory
which specifies presto native max partial aggregation memory when data reduction is optimal :pr:23527
.native_max_spill_bytes
which specifies presto native max allowed spill bytes :pr:23527
.23539
.iceberg.parquet-batch-read-optimization-enabled
is set toTRUE
. :pr:23542
.23546
.rollback_to_timestamp
to rollback an iceberg table to a given point in time. :pr:23559
.23579
.23580
./v1/info/state
to return INACTIVE state until the resource group configuration manager is fully initialized :pr:23585
.23589
.register_table
andunregister_table
:pr:12345
.hive.time-zone property
.Partitioning
,PartitioningScheme
,PartitioningHandle
,PlanFragmentId
,StageExecutionDescriptor
andSimplePlanFragment
to the SPI . :pr:23601
.23626
.async-cache-full-persistence-interval
withasync-cache-persistence-interval
. :pr:23626
.23627
.23627
.eager-plan-validation-enabled
for eager building of validation of a logical plan before queuing. :pr:23649
.ip_prefix_subnets
that splits the input prefix into subnets the size of the new prefix length. ... :pr:23656
.23710
.23714
.23739
.23760
.array_duplicates
and :func:array_has_duplicates
.23774
.:pr:23780
.23792
.23794
.23797
.23797
.23850
.23858
.23863
.23868
.23868
.23868
.23868
.23868
.iceberg.rest.auth.oauth2.scope
for OAUTH2 authentication in Iceberg's REST catalog :pr:23884
.23890
.native_max_local_exchange_partition_count session
property. :pr:23910
.23922
.All Commits
using namespace
from header files (Removeusing namespace
from header files #23575) (Richard Barnes)table
totable_name
and update docs with correct argument names (Jalpreet Singh Nanda (:imjalpreet))