Remove unused code from the Iceberg module #23944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawalreetika
requested review from
hantangwangd,
ZacBlanco and
a team
as code owners
ZacBlanco
previously approved these changes
Nov 4, 2024
hantangwangd
requested changes
Nov 4, 2024
Comment on lines
122
to
124
|
|
||
| // Convert Presto Nested Field to Iceberg NestedField | ||
| Types.NestedField nestedField = toIcebergNestedField(prestoNestedField, columnNameToIdMapping("anonymous_row")); |
There was a problem hiding this comment.
Seems we shouldn't remove this.
agrawalreetika
force-pushed
the
iceberg-cleanup
branch
from
2986d8c
to
de024f0
Compare
hantangwangd
approved these changes
Nov 4, 2024
imjalpreet
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Unrelated but should we rename this test file as TestIcebergRegisterAndUnregisterTableProcedure.java
tdcmeehan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused code from the Iceberg module.
Motivation and Context
Found a few variables, methods & classes unused in the presto-iceberg module. Tried to do some clean up as part of this.
Impact
Code cleanup
Test Plan
CI Test Run
Contributor checklist
Release Notes