Update anchored-position.ts to support handling elements outside of document.body in getClippingRect
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 666c2d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Oct 12, 2023
|
Thanks for the contribution! We just ran into this too, was so happy to find you fixed it already. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for implementing this great project and I've been enjoying using it in my project so far! This time I hope I could contribute back to the project.
My project has encountered such problem EnixCoda/Gitako#294
Minimal demo to reproduce the issue: https://codesandbox.io/s/primer-react-anchor-error-fvxcsf?file=/src/App.tsx
The key point is that the anchor element is outside of
document.body.getClippingRectdoes not expect the element to be not existing and throws error when not found.