Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ci workflow into separate jobs, add type-check job #221

Merged
merged 2 commits into from
Sep 29, 2023
Merged

ci: update ci workflow into separate jobs, add type-check job #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cac245
ci: update ci workflow into separate jobs, add type-check job
joshblack Sep 25, 2023
bcc0519
Merge branch 'main' into ci/update-ci-jobs
joshblack Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,44 @@ on:
pull_request:

jobs:
ci:
name: CI
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: Install dependencies
run: npm ci

- name: Lint
run: npm run lint

- name: Build
run: npm run build
test:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18
- name: Install dependencies
run: npm ci
- name: Run tests
run: npm test -- --ci

- name: Test
run: npm run test
type-check:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 18
- name: Install dependencies
run: npm ci
- name: Check TypeScript types
run: npm run type-check
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,17 @@
"dist/cjs/focus-trap.js"
],
"scripts": {
"lint": "eslint src/",
"test": "npm run jest && npm run lint",
"test:watch": "jest --watch",
"jest": "jest",
"clean": "rm -rf dist",
"prebuild": "npm run clean",
"build": "npm run build:esm && npm run build:cjs",
"build:esm": "tsc",
"build:cjs": "tsc --module commonjs --outDir dist/cjs",
"lint": "eslint src/",
"test": "jest",
"test:watch": "jest --watch",
"prebuild": "npm run clean",
"release": "npm run build && changeset publish",
"size-limit": "npm run build && size-limit",
"release": "npm run build && changeset publish"
"type-check": "tsc --noEmit"
},
"repository": {
"type": "git",
Expand Down
Loading