Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update @primer/octicons-react to 19.14.0 #5422

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion examples/theming/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"type-check": "tsc --noEmit"
},
"dependencies": {
"@primer/octicons-react": "^19.9.0",
"@primer/octicons-react": "^19.14.0",
"@primer/react": "37.8.0",
"clsx": "^1.2.1",
"next": "^14.2.10",
Expand Down
6 changes: 4 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1378,11 +1378,14 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav
>
<svg
aria-hidden="true"
class="c9"
class="octicon octicon-chevron-down c9"
display="inline-block"
fill="currentColor"
focusable="false"
height="16"
style="display: inline-block; user-select: none; vertical-align: text-bottom; overflow: visible;"
overflow="visible"
style="vertical-align: text-bottom;"
sx="[object Object]"
viewBox="0 0 16 16"
width="16"
>
Expand Down Expand Up @@ -1897,11 +1900,14 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t
>
<svg
aria-hidden="true"
class="c9"
class="octicon octicon-chevron-down c9"
display="inline-block"
fill="currentColor"
focusable="false"
height="16"
style="display: inline-block; user-select: none; vertical-align: text-bottom; overflow: visible;"
overflow="visible"
style="vertical-align: text-bottom;"
sx="[object Object]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this sx be inlining like this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure not, but how do we fix it?

viewBox="0 0 16 16"
width="16"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
GitBranchIcon,
CodeIcon,
CommentDiscussionIcon,
CommitIcon,
GitCommitIcon,
ChecklistIcon,
FileDiffIcon,
TriangleDownIcon,
Expand Down Expand Up @@ -126,7 +126,7 @@ export const PullRequestPage = () => (
<UnderlineNav.Item icon={CommentDiscussionIcon} counter="12" aria-current="page">
Conversation
</UnderlineNav.Item>
<UnderlineNav.Item counter={3} icon={CommitIcon}>
<UnderlineNav.Item counter={3} icon={GitCommitIcon}>
Commits
</UnderlineNav.Item>
<UnderlineNav.Item counter={7} icon={ChecklistIcon}>
Expand Down Expand Up @@ -352,7 +352,7 @@ export const WithPageLayout = () => {
<UnderlineNav.Item icon={CommentDiscussionIcon} counter="12" aria-current="page">
Conversation
</UnderlineNav.Item>
<UnderlineNav.Item counter={3} icon={CommitIcon}>
<UnderlineNav.Item counter={3} icon={GitCommitIcon}>
Commits
</UnderlineNav.Item>
<UnderlineNav.Item counter={7} icon={ChecklistIcon}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
PencilIcon,
SidebarExpandIcon,
CommentDiscussionIcon,
CommitIcon,
GitCommitIcon,
FileDiffIcon,
ChecklistIcon,
WorkflowIcon,
Expand Down Expand Up @@ -134,7 +134,7 @@ export const WithNavigationSlot = () => (
<UnderlineNav.Item icon={CommentDiscussionIcon} counter="12" aria-current="page">
Conversation
</UnderlineNav.Item>
<UnderlineNav.Item counter={3} icon={CommitIcon}>
<UnderlineNav.Item counter={3} icon={GitCommitIcon}>
Commits
</UnderlineNav.Item>
<UnderlineNav.Item counter={7} icon={ChecklistIcon}>
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/PageHeader/PageHeader.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
PeopleIcon,
PencilIcon,
CommentDiscussionIcon,
CommitIcon,
GitCommitIcon,
ChecklistIcon,
FileDiffIcon,
ArrowRightIcon,
Expand Down Expand Up @@ -270,7 +270,7 @@ export const Playground: StoryFn = args => (
<UnderlineNav.Item icon={CommentDiscussionIcon} counter="12" aria-current="page">
Conversation
</UnderlineNav.Item>
<UnderlineNav.Item counter={3} icon={CommitIcon}>
<UnderlineNav.Item counter={3} icon={GitCommitIcon}>
Commits
</UnderlineNav.Item>
<UnderlineNav.Item counter={7} icon={ChecklistIcon}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,23 @@ exports[`StateLabel renders children 1`] = `
>
<svg
aria-label="Issue"
className="c1"
className="octicon octicon-issue-opened c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -95,19 +99,23 @@ exports[`StateLabel respects the status prop 1`] = `
>
<svg
aria-label="Issue"
className="c1"
className="octicon octicon-issue-opened c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -155,19 +163,23 @@ exports[`StateLabel respects the status prop 2`] = `
>
<svg
aria-label="Issue"
className="c1"
className="octicon octicon-issue-closed c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -215,19 +227,23 @@ exports[`StateLabel respects the status prop 3`] = `
>
<svg
aria-label="Issue, not planned"
className="c1"
className="octicon octicon-skip c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -272,19 +288,23 @@ exports[`StateLabel respects the status prop 4`] = `
>
<svg
aria-label="Pull request"
className="c1"
className="octicon octicon-git-merge c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -329,19 +349,23 @@ exports[`StateLabel respects the status prop 5`] = `
>
<svg
aria-label="Pull request"
className="c1"
className="octicon octicon-git-merge-queue c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -386,19 +410,23 @@ exports[`StateLabel respects the variant prop 1`] = `
>
<svg
aria-label="Issue"
className="c1"
className="octicon octicon-issue-opened c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down Expand Up @@ -446,19 +474,23 @@ exports[`StateLabel respects the variant prop 2`] = `
>
<svg
aria-label="Issue"
className="c1"
className="octicon octicon-issue-opened c1"
display="inline-block"
fill="currentColor"
focusable="false"
height={16}
overflow="visible"
role="img"
style={
{
"display": "inline-block",
"overflow": "visible",
"userSelect": "none",
"verticalAlign": "text-bottom",
}
}
sx={
{
"mr": 1,
}
}
viewBox="0 0 16 16"
width={16}
>
Expand Down
Loading
Loading