Track and stop running processes to make it easier to run Playwright …

…in dev (#3098)

.github/workflows/test.yml

@@ -258,7 +258,7 @@ jobs:
     - name: Run Playwright tests
       id: playwright-run
       continue-on-error: true
-      run: npx playwright test --workers 6
+      run: ./script/run-playwright
     - id: auto-commit
       uses: stefanzweifel/git-auto-commit-action@v5
       with:

Procfile

@@ -1,3 +1,3 @@
-vite: cd demo; bin/vite dev
-css: cd demo; npm run build:css -- --watch
+vite: cd demo; script/start-vite
+css: cd demo; script/start-css
 web: cd demo; bin/rails s -p 4000

demo/script/start-css

@@ -0,0 +1,4 @@
+#! /bin/bash
+
+echo $$ > tmp/pids/css.pid
+exec npm run build:css -- --watch

demo/script/start-vite

@@ -0,0 +1,4 @@
+#! /bin/bash
+
+echo $$ > tmp/pids/vite.pid
+exec bin/vite dev

playwright.config.ts

@@ -23,29 +23,29 @@ const config: PlaywrightTestConfig = {
     baseURL: 'http://127.0.0.1:4000',
     browserName: 'chromium',
     headless: true,
-    screenshot: 'only-on-failure'
+    screenshot: 'only-on-failure',
   },
   expect: {
     toHaveScreenshot: {
-      animations: 'disabled'
+      animations: 'disabled',
     },
     toMatchSnapshot: {
-      threshold: 0.1
-    }
+      threshold: 0.1,
+    },
   },
   /* Retry on CI only */
   retries: process.env.CI ? 2 : 0,
 
   reporter: [
     ['line'],
     ['html', {open: 'never', outputFolder: path.join(__dirname, '.playwright/report')}],
-    ['json', {outputFile: path.join(__dirname, '.playwright', 'results.json')}]
+    ['json', {outputFile: path.join(__dirname, '.playwright', 'results.json')}],
   ],
 
   webServer: {
-    command: 'overmind start',
-    port: 4000
-  }
+    command: 'script/dev',
+    port: 4000,
+  },
 }
 
 export default config

script/dev

@@ -18,6 +18,8 @@ bundle check || bundle install
 npm install --ignore-scripts
 popd
 
+./script/stop-existing-processes
+
 while [[ "$#" > 0 ]]; do case $1 in
   -d|--debug) debug="1"; shift;;
 esac; done

script/run-playwright

@@ -0,0 +1,4 @@
+#! /bin/bash
+
+./script/stop-existing-processes
+exec npx playwright test --workers 6

script/stop-existing-processes

@@ -0,0 +1,17 @@
+#! /bin/bash
+
+overmind stop
+rm .overmind.sock
+
+pidfiles=(demo/tmp/pids/css.pid demo/tmp/pids/vite.pid demo/tmp/pids/server.pid)
+
+for pidfile in "${pidfiles[@]}"
+do
+  if [ -f $pidfile ]; then
+    pid=$(cat $pidfile)
+    name=$(basename "$pidfile" .pid)
+    echo "Stopping existing $name process with pid $pid"
+    kill -9 $pid
+    rm $pidfile
+  fi
+done