Remove SystemArgumentInsteadOfClass linter and fix bug with whitespac…

…e in rendered class (#3220)
primer · Dec 5, 2024 · 688a4a2 · 688a4a2
1 parent ebcd187
commit 688a4a2
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 125 deletions.
diff --git a/.changeset/wet-houses-own.md b/.changeset/wet-houses-own.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Remove SystemArgumentInsteadOfClass linter and fix bug with whitespace in rendered class
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -57,9 +57,6 @@ Primer/NoTagMemoize:
   Include:
     - "app/components/**/*"
 
-Primer/SystemArgumentInsteadOfClass:
-  Enabled: true
-
 Lint/MissingSuper:
   Enabled: false
 

diff --git a/docs/contributors/linting.md b/docs/contributors/linting.md
@@ -18,7 +18,7 @@ inherit_gem:
 You can also modify that configuration enabling/disabling the cops you want:
 
 ```yml
-Primer/SystemArgumentInsteadOfClass:
+Primer/NoTagMemoize:
   Enabled: false
 ```
 

diff --git a/lib/primer/classify.rb b/lib/primer/classify.rb
@@ -49,7 +49,7 @@ def call(args = {})
             case key
             when :classes
               # insert :classes first to avoid huge doc diffs
-              result.unshift(val)
+              result.unshift(val) unless val.blank?
               next
             when :style
               style = val

diff --git a/lib/rubocop/config/default.yml b/lib/rubocop/config/default.yml
@@ -1,9 +1,6 @@
 require:
   - rubocop/cop/primer
 
-Primer/SystemArgumentInsteadOfClass:
-  Enabled: true
-
 Primer/NoTagMemoize:
   Enabled: false
 

diff --git a/lib/rubocop/cop/primer/system_argument_instead_of_class.rb b/lib/rubocop/cop/primer/system_argument_instead_of_class.rb
diff --git a/test/components/base_component_test.rb b/test/components/base_component_test.rb
@@ -73,6 +73,12 @@ def test_does_not_render_class_attribute_if_none_is_set
     refute_selector("div[class='']")
   end
 
+  def test_renders_system_argument_class_with_no_whitespace
+    render_inline(Primer::BaseComponent.new(tag: :div, ml: 3))
+
+    assert_selector("div[class='ml-3']")
+  end
+
   def test_does_not_render_primer_layout_classes_as_attributes
     render_inline(Primer::BaseComponent.new(tag: :div, my: 4))
 

diff --git a/test/lib/rubocop/system_arguments_instead_of_class_test.rb b/test/lib/rubocop/system_arguments_instead_of_class_test.rb