Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take snapshots of form previews #3203

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Take snapshots of form previews #3203

merged 5 commits into from
Nov 25, 2024

Conversation

camertron
Copy link
Contributor

What are you trying to accomplish?

We were alerted to an issue last week that could have been caught by visual regression testing (VRT). This PR adds snapshots for form previews to our VRT suite.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@camertron camertron added the skip changeset Pull requests that don't change the library output label Nov 19, 2024
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 0233797

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review November 21, 2024 04:37
@camertron camertron requested review from a team as code owners November 21, 2024 04:37
@camertron camertron requested review from langermank and jonrohan and removed request for langermank November 21, 2024 04:37
@camertron camertron merged commit 5d9fab3 into main Nov 25, 2024
34 checks passed
@camertron camertron deleted the snapshot_form_previews branch November 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants