Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pulse railway starter app+ db docs #5734

Merged
merged 36 commits into from
Mar 25, 2024
Merged

feat: add pulse railway starter app+ db docs #5734

merged 36 commits into from
Mar 25, 2024

Conversation

ankur-arch
Copy link
Contributor

No description provided.

@ankur-arch ankur-arch self-assigned this Mar 19, 2024
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 9:02am

Copy link
Contributor

github-actions bot commented Mar 19, 2024

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

Copy link
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 45.9%, saving 129.27 KB.

Filename Before After Improvement Visual comparison
content/400-pulse/images/railway-database-url.png 281.54 KB 152.28 KB -45.9% View diff

158 images did not require optimisation.

Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first round of feedback for the "DB only" template. tackling the one with the app starter next.

overall: this looks much better compared to yesterday already!! 💪

content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving some change requests already but the step-by-step instructions in the Setup with template: “Prisma Pulse DB & App” section need to be more accurate/detailed. (See Slack for more info.)

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 23.4%, saving 176.40 KB.

Filename Before After Improvement Visual comparison
content/400-pulse/images/railway-template-configure.png 754.53 KB 578.13 KB -23.4% View diff

159 images did not require optimisation.

content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
content/400-pulse/250-database-setup/300-railway.mdx Outdated Show resolved Hide resolved
ankur-arch and others added 13 commits March 21, 2024 21:59
@ankur-arch ankur-arch merged commit c0e879e into main Mar 25, 2024
5 of 6 checks passed
@ankur-arch ankur-arch deleted the railway-update branch March 25, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants