chore(fmt/psl): update find at position w/ spans #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… until whatever comes next. This means we have a wider span to use for empty arguments and enables us to check for cursors that are where the ""value"" would be but there is no actual value yet. EnumValuePosition was manually calculating attribute positions, this has been removed - it now defers to the AttributePosition implementation. Updating the positions in `find_at_position` to also include spans Extracted out reference_locations_for_target to separate module in prep for other lsp commands (e.g. rename)
Druue
commented
Jul 17, 2024
| @@ -114,7 +114,7 @@ field_attribute = { "@" ~ path ~ arguments_list? } | |||
| // ###################################### | |||
| arguments_list = { "(" ~ (argument ~ ("," ~ argument)*)? ~ trailing_comma? ~ ")" } | |||
| argument = _{ named_argument | empty_argument | expression } | |||
| empty_argument = { identifier ~ ":" } | |||
There was a problem hiding this comment.
This allows us an empty argument span that includes all the whitespace until the next , or ).
Druue
commented
Jul 17, 2024
| } | ||
|
|
||
| impl<'ast> AttributePosition<'ast> { | ||
| pub(crate) fn new(attr: &'ast ast::Attribute, position: usize) -> Self { | ||
| let mut spans: Vec<(Option<&str>, ast::Span)> = attr |
There was a problem hiding this comment.
This is no longer necessary due to the addition of a whitespace inclusive span for empty args. We can just use contains now.
CodSpeed Performance ReportMerging #4957 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated pest grammar for empty argument to include the whitespaces up until whatever comes next. This means we have a wider span to use for empty arguments and enables us to check for cursors that are where the ""value"" would be but there is no actual value yet.
EnumValuePosition was manually calculating attribute positions, this has been removed - it now defers to the AttributePosition implementation.
Updating the positions in
find_at_positionto also include spansExtracted out reference_locations_for_target to separate module in prep for other lsp commands (e.g. rename)