-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: timed out fetching a new connection from the connection pool. #4998
base: main
Are you sure you want to change the base?
Conversation
Is this ready to merge? |
Thanks so much for the PR and sorry for the delay, I'll get to it soon (tomorrow or early next week). |
CodSpeed Performance ReportMerging #4998 will not alter performanceComparing Summary
|
d0d7720
to
da82b63
Compare
I have fixed the lint issue. Please help trigger the checks workflow again. Thanks. |
Would love to see this merged |
Seeing this error in production environment, even using pgbouncer, would be nice to ship this in the next release |
Agreed with others! We are having similar issues as well and it would be great to see this make it into a release. Even if there is was an RC or beta to test it out to get more consensus and field testing if that would help community feel better about it. |
Looks like this has stalled out again, we are seeing this issue on our live app |
fix (prisma/prisma#25162)
solution
Change
new MakeTlsConnector
, which is executed by eachPostgreSql::new
, to obtain it fromMakeTlsConnectorManager.get_connector
. The logic ofget_connector
is to createnew MakeTlsConnector
in the first call and save the created tls connector. All subsequent calls will clone the tls connector from the first call, thereby reducing the overhead of thenew MakeTlsConnector
.test results
Use https://github.com/youxq/prisma-connection-test tool to test.
The bug of
Timed out fetching a new connection from the connection pool.
was successfully triggered before the fix.It no longer appears after the fix.