Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mobc and metrics crates #5015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update mobc and metrics crates #5015

wants to merge 2 commits into from

Conversation

SevInf
Copy link
Member

@SevInf SevInf commented Oct 8, 2024

mobc update includes fixes from importcjj/mobc#99
Rest of the PR is update to new api of the metrics crate.

Close prisma/team-orm#1317

@SevInf SevInf requested a review from a team as a code owner October 8, 2024 15:48
@SevInf SevInf requested review from aqrln and removed request for a team October 8, 2024 15:48
@SevInf SevInf added this to the 5.21.0 milestone Oct 8, 2024
Copy link

codspeed-hq bot commented Oct 8, 2024

CodSpeed Performance Report

Merging #5015 will not alter performance

Comparing mobc-and-metrics-up (25e5b67) with main (00f0d73)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Oct 8, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.714MiB 2.708MiB 6.264KiB
Postgres (gzip) 1.039MiB 1.036MiB 2.411KiB
Mysql 2.039MiB 2.035MiB 4.053KiB
Mysql (gzip) 814.856KiB 812.539KiB 2.318KiB
Sqlite 1.932MiB 1.928MiB 3.679KiB
Sqlite (gzip) 772.380KiB 770.432KiB 1.949KiB

PRISMA_CLIENT_QUERIES_DURATION_HISTOGRAM_MS,
operation_timer.elapsed_time()
);
histogram!(PRISMA_CLIENT_QUERIES_DURATION_HISTOGRAM_MS,).record(operation_timer.elapsed_time());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the macro require the trailing comma?

mobc update includes fixes from importcjj/mobc#99
Rest of the PR is update to new api of the `metrics` crate.

Close prisma/team-orm#1317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants