Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple config creation from VerifyingKey::read #206

Closed
wants to merge 1 commit into from

Conversation

Liuhaai
Copy link

@Liuhaai Liuhaai commented Sep 15, 2023

This PR aims to simplify the loading of ProvingKey and VerifyingKey.
Since config from VerifyingKey::read is only used in keygen_vk, the config creation is separated as create_config func which is called immediately after create_domain func in keygen_vk.
This refactoring will remove the requirement of params and concrete circuit when deserializing the ProvingKey and VerifyingKey from bytes. e.g. https://github.com/privacy-scaling-explorations/halo2/pull/206/files#diff-073662488bf261a70d2143e3a1da2e9e61511216975fbdb13833c8253b819df8R146

@CPerezz
Copy link
Member

CPerezz commented Sep 16, 2023

Approved to run the tests.

I just skimmed through this and did not look bad.
But want to take a deeper & closer look next week.

Copy link

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes the cs always empty in vk, the ConcreteCircuit generic would be required as long as cs is not serialized.

@Liuhaai Liuhaai closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants