Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix/optimization] mul_by_3b special case should be CURVE_ID == "bn256_g1" #101

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[fix/optimization] mul_by_3b special case should be CURVE_ID == "bn256_g1" #101

merged 1 commit into from
Nov 17, 2023

Conversation

jonathanpwang
Copy link
Contributor

It seems this special case optimization was not being triggered because the CURVE_ID didn't match.

davidnevadoc
davidnevadoc approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@davidnevadoc davidnevadoc added this pull request to the merge queue Nov 17, 2023
Merged via the queue into privacy-scaling-explorations:main with commit 985d16e Nov 17, 2023
7 checks passed
@CPerezz CPerezz mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidnevadoc davidnevadoc davidnevadoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanpwang @davidnevadoc