Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated iso curve #160

Merged

Conversation

kilic
Copy link
Collaborator

@kilic kilic commented May 30, 2024

I'm chunking huge BLS12 addition PR #159 into smaller pieces. This is the first leg that removes useless iso curve generation

@kilic kilic mentioned this pull request May 30, 2024
@davidnevadoc davidnevadoc self-requested a review June 6, 2024 08:00
Copy link
Contributor

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the last commit. Most of the comments are just potential doc improvements.
Great job! :)

src/hash_to_curve.rs Outdated Show resolved Hide resolved
src/hash_to_curve.rs Outdated Show resolved Hide resolved
src/secp256k1/curve.rs Show resolved Hide resolved
src/secp256r1/curve.rs Show resolved Hide resolved
src/hash_to_curve.rs Show resolved Hide resolved
src/hash_to_curve.rs Show resolved Hide resolved
src/secp256r1/curve.rs Outdated Show resolved Hide resolved
@kilic kilic force-pushed the remove-iso-curve branch from e90fc56 to 99ce5d3 Compare June 13, 2024 11:40
@davidnevadoc davidnevadoc changed the base branch from main to v0.4.0 June 17, 2024 20:22
@davidnevadoc davidnevadoc changed the base branch from v0.4.0 to main June 17, 2024 20:23
kilic added 3 commits June 24, 2024 19:31
stay projective in the end of sswu mapping
bring back removed comments
@kilic kilic force-pushed the remove-iso-curve branch from 99ce5d3 to d2c839e Compare June 24, 2024 16:44
Copy link
Contributor

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@davidnevadoc davidnevadoc added this pull request to the merge queue Jun 25, 2024
Merged via the queue into privacy-scaling-explorations:main with commit ec576f8 Jun 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants