Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor field tests #166

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Refactor field tests #166

merged 12 commits into from
Oct 1, 2024

Conversation

davidnevadoc
Copy link
Contributor

@davidnevadoc davidnevadoc commented Jun 25, 2024

Description

This PR refactors the field tests to achieve 2 goals:

  • More granularity: Unpack tests that were previously just 1. This allows us to spot the failures precisely quicker.
  • Reducing macro code.

Changes

  • Field tests refactor
  • Modification of unused PrimeField constants for quadratic-extension fields in BN and BLS curves.
  • Minor typos.

Future work

Do the same for curves.

@davidnevadoc davidnevadoc marked this pull request as ready for review September 22, 2024 11:10
Copy link
Member

@adria0 adria0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some comments and clarifications

src/bls12381/fq12.rs Show resolved Hide resolved
src/bls12381/fq.rs Outdated Show resolved Hide resolved
src/bls12381/fq.rs Show resolved Hide resolved
src/bls12381/fq2.rs Outdated Show resolved Hide resolved
src/tests/field/serde.rs Outdated Show resolved Hide resolved
src/tests/field/legendre.rs Show resolved Hide resolved
src/tests/field/legendre.rs Show resolved Hide resolved
src/pluto_eris/fp2.rs Outdated Show resolved Hide resolved
src/ff_ext/cubic.rs Show resolved Hide resolved
src/bn256/fq6.rs Outdated Show resolved Hide resolved
@davidnevadoc davidnevadoc added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 8771fe5 Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants