Matrix transpose bitorder #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themighty1
requested changes
Jul 11, 2023
| fn transpose_naive(data: &[u8], row_width: usize) -> Vec<u8> { | ||
| use itybity::*; | ||
|
|
||
| let bits: Vec<Vec<bool>> = data.chunks(row_width).map(|x| x.to_lsb0_vec()).collect(); |
There was a problem hiding this comment.
isn't row_width the width in bits ? here it is treated as if it was in bytes
There was a problem hiding this comment.
I think it is correct here to use the row width in bytes, because we iterate in chunks of byte rows and turn this chunk into bit rows. So in the beginning it is bytes and after this operation it is bits.
themighty1
requested changes
Jul 13, 2023
|
I don't see any failing tests, try |
|
I'm going to merge this, it is blocking #37. Changes to CI etc can be done in another PR |
sinui0
added a commit
that referenced
this pull request
Aug 30, 2023
* add naive test * Change algorithm to work for LSB0 encoding instead of MSB0 * add test --------- Co-authored-by: th4s <[email protected]> Co-authored-by: themighty1 <[email protected]>
sinui0
added a commit
that referenced
this pull request
Aug 30, 2023
* add naive test * Change algorithm to work for LSB0 encoding instead of MSB0 * add test --------- Co-authored-by: th4s <[email protected]> Co-authored-by: themighty1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR flips the bit order of the resulting transposed matrix