Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fix spelling issues #152

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nnsW3
Copy link

@nnsW3 nnsW3 commented Aug 28, 2024

Hello
I found several spelling issues.
Hope it helps
Br, Elias.

@arnaucube
Copy link
Collaborator

Hi @nnsW3 , thanks for the typos fixes. In this repo some months ago we added into the CI pipeline the tool typos to prevent many typos from happening, but it will only detect miss-spellings of words, not wrong usages or errors on sentences as the ones that you're fixing in this PR.

From what I see in your github profile, eg. Cyfrin/foundry-full-course-cu#2301, starkware-libs/blockifier#2108, near/nearcore#11906, matter-labs/zksync-era#2611 , etc (more than 100 PRs to different projects fixing typos), seems like you're using some more advanced tool to detect these kind of typos that are not misspelling of words but more like sentence errors or wrong usage of words.

Is it some tool that we could integrate in the CI pipeline of this repo, so that future similar typos can be automatically detected avoiding more human friction?
Thanks in advance.

@CPerezz
Copy link
Member

CPerezz commented Oct 2, 2024

Seems he's not going to get back to us. Likely a script that is farming airdrops.

@CPerezz
Copy link
Member

CPerezz commented Oct 2, 2024

Can we close this @arnaucube? SO we have less PRs to navigate through

@nnsW3
Copy link
Author

nnsW3 commented Oct 2, 2024

Hi @nnsW3 , thanks for the typos fixes. In this repo some months ago we added into the CI pipeline the tool typos to prevent many typos from happening, but it will only detect miss-spellings of words, not wrong usages or errors on sentences as the ones that you're fixing in this PR.

From what I see in your github profile, eg. Cyfrin/foundry-full-course-cu#2301, starkware-libs/blockifier#2108, near/nearcore#11906, matter-labs/zksync-era#2611 , etc (more than 100 PRs to different projects fixing typos), seems like you're using some more advanced tool to detect these kind of typos that are not misspelling of words but more like sentence errors or wrong usage of words.

Is it some tool that we could integrate in the CI pipeline of this repo, so that future similar typos can be automatically detected avoiding more human friction? Thanks in advance.

no, I have done it manually and spent a lot of time finding errors
I just try to contribute to the space with my knowledge. I'm just a junior developer yet...
so more meaningful contributions are out of my hand for now...

@arnaucube
Copy link
Collaborator

But, are you reading line by line all those repositories where you open PRs fixing issues in order to find those kind of typos? We're talking about more than 100 PRs to 100 different repos, each of them with thousands lines of code. I would use some tool instead.

I was asking because maybe we can integrate that tool in the CI so that in the future similar typos are detected automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants