Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smt): fix verify proof membership #60

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix(smt): fix verify proof membership #60

merged 1 commit into from
Oct 18, 2024

Conversation

waddaboo
Copy link
Contributor

Description

This PR fixes the issue of membership is not explicitly being used in verify_proof.

The solution was suggested by @0xDatapunk.

Related Issue(s)

Closes #58
Closes #59

Other information

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run make lint and cargo build --release without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

0xDatapunk
0xDatapunk reviewed Oct 18, 2024
View reviewed changes
Copy link

@0xDatapunk 0xDatapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this fixes both issues

@cedoor cedoor merged commit f68f6e4 into privacy-scaling-explorations:main Oct 18, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Merged
cedoor pushed a commit that referenced this pull request Oct 18, 2024
@github-actions
chore(zk-kit-smt): release v0.0.6 (#61)
97785ff 
## 🤖 New release
* `zk-kit-smt`: 0.0.5 -> 0.0.6

<details><summary><i><b>Changelog</b></i></summary><p>

## `zk-kit-smt`
<blockquote>

##
[0.0.6](zk-kit-smt-v0.0.5...zk-kit-smt-v0.0.6)
- 2024-10-18

### Fixed
- *(smt)* fix verify proof membership
([#60](#60))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDatapunk 0xDatapunk 0xDatapunk left review comments

@cedoor cedoor cedoor approved these changes

@sripwoud sripwoud Awaiting requested review from sripwoud sripwoud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@waddaboo @cedoor @0xDatapunk