Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update!: Create separate page for Pastebins #2598

Merged
merged 1 commit into from
Jul 21, 2024
Merged

update!: Create separate page for Pastebins #2598

merged 1 commit into from
Jul 21, 2024

Conversation

redoomed1
Copy link
Member

@redoomed1 redoomed1 commented Jun 1, 2024

Changes proposed in this PR:

  • Create a separate recommendation page for pastebins
  • Add Pastebins section in tools.md and move PrivateBin entry to it
  • Delete "Paste services" section from the Productivity Tools page

This is my first PR that involves an image upload, so I welcome any feedback in this department! I went over https://www.privacyguides.org/en/meta/uploading-images, but there isn't any guidance on WebP images, which is the preferred format for cover images.

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

Copy link

github-actions bot commented Jun 1, 2024

Your preview is ready!

Name Link
🔨 Latest commit f399643
😎 Preview https://2598--glowing-salamander-8d7127.netlify.app/

@redoomed1 redoomed1 marked this pull request as ready for review June 1, 2024 15:27
@redoomed1
Copy link
Member Author

How I went about optimizing the Unsplash image linked in my initial post:

  1. Download it as a .jpg file
  2. Use cwebp to convert it to a WebP file by running cwebp -size 300000 [image-name].jpg -o pastebins.webp

-size specifies target size in bytes. I set it to 300,000 bytes (300 KB) because, of all the cover images on the site, the one for the Desktop Browsers page is the largest at 305 KB.

@jonaharagon
Copy link
Member

jonaharagon commented Jun 1, 2024

Good note, we should probably document WebP optimization. IIRC all the existing images were a pre-set quality level but I don't remember what that setting was. I'll do that later.

@redoomed1 redoomed1 changed the title Create separate page for Pastebins update: Create separate page for Pastebins Jun 2, 2024
@redoomed1 redoomed1 changed the title update: Create separate page for Pastebins feat: Create separate page for Pastebins Jun 20, 2024
@jonaharagon jonaharagon changed the title feat: Create separate page for Pastebins update!: Create separate page for Pastebins Jul 15, 2024
@dngray dngray added the c:enhancements new features or other enhancements to the website itself label Jul 19, 2024
@dngray dngray merged commit f399643 into privacyguides:main Jul 21, 2024
11 checks passed
@redoomed1 redoomed1 deleted the add-pastebins-page branch July 21, 2024 16:13
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-21/19599/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants