Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial homepage redesign #2621

Merged
merged 1 commit into from
Jul 21, 2024
Merged

feat: Initial homepage redesign #2621

merged 1 commit into from
Jul 21, 2024

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Jun 20, 2024

Changes proposed in this PR:

2024-06-20 at 20 19 53

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

@jonaharagon jonaharagon requested a review from dngray as a code owner June 20, 2024 11:19
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/homepage-redesign/19019/4

@jonaharagon
Copy link
Member Author

I made the forum posts nicer for you @freddy-m

@jonaharagon jonaharagon requested a review from freddy-m June 20, 2024 11:23
Copy link

github-actions bot commented Jun 20, 2024

Your preview is ready!

Name Link
🔨 Latest commit 1b99537
😎 Preview https://2621--glowing-salamander-8d7127.netlify.app/

@@ -17,6 +17,12 @@ HOMEPAGE_RSS_STORIES_LINK="https://share.privacyguides.org/web-stories/feed/"
HOMEPAGE_RSS_STORIES_TITLE="Privacy Guides web stories feed"
HOMEPAGE_RSS_FORUM_LINK="https://discuss.privacyguides.net/latest.rss"
HOMEPAGE_RSS_FORUM_TITLE="Latest Privacy Guides forum topics"
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community."
Copy link
Member

@redoomed1 redoomed1 Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header is kind of a mouthful when reading it. Thoughts on this change?

Suggested change
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community."
HOMEPAGE_HEADER="A collaborative community advocating for personal privacy."

Is the adjective "personal" modifying "privacy" or "community" in your original header?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can leave the word personal out: "community advocating for privacy". It doesn't add much and privacy is personal anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others to consider:

Suggested change
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community."
HOMEPAGE_HEADER="The collaborative personal privacy community."
Suggested change
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community."
HOMEPAGE_HEADER="The crowdsourced personal privacy community."

I would also be open to an entirely different sentence if we have any ideas.

@ph00lt0 I added personal to distinguish our organization from orgs like https://iapp.org/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just think it is long. Like the packaging you showed on the forum as inspiration I think it's best to stay consise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't like the current version. I'd probably prefer to drop advocacy than personal if we shorten it, I think.

theme/home.html Outdated
@@ -43,28 +43,27 @@ <h1>{{ homepage.hero.header }}</h1>
{{ button.name }}
</a>
{% endfor %}
{% if config.theme.language == "en" %}
<a href="https://discuss.privacyguides.net/" title="Join the Privacy Guides forum" class="md-button">
Ask A Question
Copy link
Member

@redoomed1 redoomed1 Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like showcasing a link to the Discourse forum (it is one of the strengths of Privacy Guides after all), but I'm not sure about the button text.

Ideally, people who land on the site for the first time would browse the Knowledge Base or Recommendations before asking a question on the forum, rather than ask a question on the forum that is already answered on the site, with a community member responding by providing a link to the relevant page (here is a recent example of this). This is just my opinion though; I would love other people's take on this.

Suggested change
Ask A Question
Join Our Community

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i prefer the ask a question. It's more of a low barrier than having to sign up for something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more of a low barrier than having to sign up for something.

This was also my thought process, so I don't think I like @redoomed1's suggested change here, but I'm open to other suggestions that aren't just saying "join us" too, because ask a question isn't great either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something along the lines of "Participate in [...]"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further reflection, I think we should just not add this button at all actually.

HOMEPAGE_SUBHEADER="Privacy Guides is a not-for-profit, volunteer-run project that hosts online communities and publishes news and recommendations surrounding privacy and security tools, services, and knowledge."
HOMEPAGE_BUTTON_GET_STARTED_NAME="Start Your Privacy Journey"
HOMEPAGE_BUTTON_GET_STARTED_TITLE="The first step of your privacy journey"
HOMEPAGE_BUTTON_TOOLS_NAME="Find Recommended Tools"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just “find recommendations” ? Think these buttons are best if compact.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually expanded it from "Recommended Tools" to add that action word which I think is better. Find Recommendations... could work, but I'd also prefer to keep the word "Tools" on the homepage.

@freddy-m
Copy link
Member

@jonaharagon the forum posts look so much nicer now, thank you! The new design looks good so far, though I do slightly miss the curves of our current site. Will add some more comments down the line

@freddy-m freddy-m added the c:enhancements new features or other enhancements to the website itself label Jun 21, 2024
@jonaharagon jonaharagon changed the title Initial homepage redesign feat: Initial homepage redesign Jul 14, 2024
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/why-is-the-privacy-guides-homepage-now-bloated/19306/8

@jonaharagon jonaharagon force-pushed the initial-homepage-redesign branch 2 times, most recently from 511da1d to 0b01d99 Compare July 21, 2024 06:31
@dngray dngray force-pushed the initial-homepage-redesign branch from 0b01d99 to 1b99537 Compare July 21, 2024 14:50
@dngray dngray merged commit 1b99537 into main Jul 21, 2024
19 checks passed
@dngray dngray deleted the initial-homepage-redesign branch July 21, 2024 15:11
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-21/19599/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants