-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial homepage redesign #2621
Conversation
This pull request has been mentioned on Privacy Guides. There might be relevant details there: https://discuss.privacyguides.net/t/homepage-redesign/19019/4 |
I made the forum posts nicer for you @freddy-m |
✅ Your preview is ready!
|
includes/strings.en.env
Outdated
@@ -17,6 +17,12 @@ HOMEPAGE_RSS_STORIES_LINK="https://share.privacyguides.org/web-stories/feed/" | |||
HOMEPAGE_RSS_STORIES_TITLE="Privacy Guides web stories feed" | |||
HOMEPAGE_RSS_FORUM_LINK="https://discuss.privacyguides.net/latest.rss" | |||
HOMEPAGE_RSS_FORUM_TITLE="Latest Privacy Guides forum topics" | |||
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header is kind of a mouthful when reading it. Thoughts on this change?
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community." | |
HOMEPAGE_HEADER="A collaborative community advocating for personal privacy." |
Is the adjective "personal" modifying "privacy" or "community" in your original header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can leave the word personal out: "community advocating for privacy". It doesn't add much and privacy is personal anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others to consider:
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community." | |
HOMEPAGE_HEADER="The collaborative personal privacy community." |
HOMEPAGE_HEADER="A collaborative personal privacy advocacy community." | |
HOMEPAGE_HEADER="The crowdsourced personal privacy community." |
I would also be open to an entirely different sentence if we have any ideas.
@ph00lt0 I added personal to distinguish our organization from orgs like https://iapp.org/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just think it is long. Like the packaging you showed on the forum as inspiration I think it's best to stay consise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't like the current version. I'd probably prefer to drop advocacy than personal if we shorten it, I think.
theme/home.html
Outdated
@@ -43,28 +43,27 @@ <h1>{{ homepage.hero.header }}</h1> | |||
{{ button.name }} | |||
</a> | |||
{% endfor %} | |||
{% if config.theme.language == "en" %} | |||
<a href="https://discuss.privacyguides.net/" title="Join the Privacy Guides forum" class="md-button"> | |||
Ask A Question |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like showcasing a link to the Discourse forum (it is one of the strengths of Privacy Guides after all), but I'm not sure about the button text.
Ideally, people who land on the site for the first time would browse the Knowledge Base or Recommendations before asking a question on the forum, rather than ask a question on the forum that is already answered on the site, with a community member responding by providing a link to the relevant page (here is a recent example of this). This is just my opinion though; I would love other people's take on this.
Ask A Question | |
Join Our Community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i prefer the ask a question. It's more of a low barrier than having to sign up for something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more of a low barrier than having to sign up for something.
This was also my thought process, so I don't think I like @redoomed1's suggested change here, but I'm open to other suggestions that aren't just saying "join us" too, because ask a question isn't great either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something along the lines of "Participate in [...]"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further reflection, I think we should just not add this button at all actually.
includes/strings.en.env
Outdated
HOMEPAGE_SUBHEADER="Privacy Guides is a not-for-profit, volunteer-run project that hosts online communities and publishes news and recommendations surrounding privacy and security tools, services, and knowledge." | ||
HOMEPAGE_BUTTON_GET_STARTED_NAME="Start Your Privacy Journey" | ||
HOMEPAGE_BUTTON_GET_STARTED_TITLE="The first step of your privacy journey" | ||
HOMEPAGE_BUTTON_TOOLS_NAME="Find Recommended Tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just “find recommendations” ? Think these buttons are best if compact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually expanded it from "Recommended Tools" to add that action word which I think is better. Find Recommendations... could work, but I'd also prefer to keep the word "Tools" on the homepage.
@jonaharagon the forum posts look so much nicer now, thank you! The new design looks good so far, though I do slightly miss the curves of our current site. Will add some more comments down the line |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: https://discuss.privacyguides.net/t/why-is-the-privacy-guides-homepage-now-bloated/19306/8 |
511da1d
to
0b01d99
Compare
Signed-off-by: Daniel Gray <[email protected]>
0b01d99
to
1b99537
Compare
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Changes proposed in this PR:
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.