Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move Hardware Guide to Knowledge Base #2669

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

redoomed1
Copy link
Member

@redoomed1 redoomed1 commented Jul 28, 2024

Changes proposed in this PR:

  • Move the recently published Hardware Guide to the Knowledge Base
    • I'm not sure what happened to the commit mentioned here; regardless, the entry currently in mkdocs.yml is not consistent with the rest in the "Recommendations" section. In my opinion, this page being in the KB makes a lot of sense since it doesn't offer tool recommendations in the same way that other pages (like any of the recently split Android pages) do.
  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

Copy link

github-actions bot commented Jul 28, 2024

Your preview is ready!

Name Link
🔨 Latest commit a7662a1
😎 Preview https://2669--glowing-salamander-8d7127.netlify.app/

@redoomed1
Copy link
Member Author

redoomed1 commented Jul 28, 2024

I do think that, somewhere in the Hardware section of the Recommended Tools, there should be a link to this KB article, in the same way that the recommendation pages for Password Managers and VPNs feature a link back to their respective KB article.

@jonaharagon
Copy link
Member

This is unfortunate, a version was merged that I've never reviewed or approved :(

Probably have to look through the hardware PR to check for other unknown changes.

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell the change you mentioned from e037fd7 is the only change that was missing in the PR...

@dngray
Copy link
Member

dngray commented Jul 29, 2024

That might have been my mistake.

@dngray dngray added the t:correction content corrections or errors label Jul 29, 2024
Signed-off-by: Jonah Aragon <[email protected]>
Signed-off-by: Daniel Gray <[email protected]>
@dngray dngray merged commit a7662a1 into privacyguides:main Jul 29, 2024
2 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-29-a58f090/19733/1

@redoomed1 redoomed1 deleted the move-hardware-guide branch July 30, 2024 04:14
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-08-01/19809/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants