Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicode support for correction char #1909

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

H3rnand3zzz
Copy link
Contributor

  • No need to run valgrind when using my new feature

How to test the functionality

  • Set correction char to unicode character, e.g. /correction char 🖋️
  • Use /correct command

@jubalh jubalh self-requested a review November 3, 2023 07:39
@jubalh jubalh added this to the next milestone Nov 3, 2023
@jubalh
Copy link
Member

jubalh commented Nov 3, 2023

Oh wow!

This was the commit to allow it in omemo/pgp/otr chars:
1f8b1eb

We must have missed this in:
5cf6ee1

Can you please mention this in the commit message?

Commit to allow unicode support in omemo/pgp/otr chars misses
adding support to set correction character.
1f8b1eb

Further fixing commit also misses adding support to set the unicode character,
it only adds ability to display unicode correction character in the settings.
5cf6ee15cf6ee1bc6d0b99b01891bc455a657bf022a72b0
@H3rnand3zzz
Copy link
Contributor Author

@jubalh, done

@jubalh jubalh merged commit 0b957d6 into profanity-im:master Nov 3, 2023
6 checks passed
@jubalh
Copy link
Member

jubalh commented Nov 3, 2023

Thanks!

@H3rnand3zzz H3rnand3zzz deleted the fix/correction-char branch November 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants