Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #1942

Merged
merged 8 commits into from
Dec 14, 2023
Merged

Minor improvements #1942

merged 8 commits into from
Dec 14, 2023

Conversation

sjaeckel
Copy link
Member

@sjaeckel sjaeckel commented Dec 9, 2023

Check commit messages for details

@sjaeckel sjaeckel self-assigned this Dec 9, 2023
@jubalh jubalh added this to the next milestone Dec 10, 2023
@sjaeckel sjaeckel changed the base branch from some-fixes to master December 12, 2023 15:35
@sjaeckel sjaeckel marked this pull request as ready for review December 12, 2023 15:51
@sjaeckel sjaeckel requested a review from jubalh December 12, 2023 15:51
Use a singleton `Jid` inside the connection instead of always re-creating
a `Jid` from the same string.

Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
* Fix missing destruction of `session_store` and mutex
* Replace `glib_hash_table_free()`
  The glib API `g_hash_table_destroy()` does exactly the same.
* Use the default libsignal `destroy_func` instead of doing that manually
* Set internal state to `0` after everything is cleaned up

Signed-off-by: Steffen Jaeckel <[email protected]>
Instead of always repeating the same pattern, introduce a helper function.

Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
Copy link
Member

@jubalh jubalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks fine. Some interesting things there!
The only thing that I need to check again (hopefully tomorrow) is the Simplify usage of roster_get_display_name() commit.

@jubalh jubalh merged commit 605ee6e into master Dec 14, 2023
6 checks passed
@jubalh jubalh deleted the minor-improvements branch December 14, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants