fix: avoid crash on insert ~ default values.

project-tsurugi · Jul 7, 2024 · 7941405 · 7941405
1 parent 6368659
commit 7941405
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/mizugaki/analyzer/details/analyze_statement.cpp b/src/mizugaki/analyzer/details/analyze_statement.cpp
@@ -194,7 +194,7 @@ class engine {
             context_.report(
                     sql_analyzer_code::unsupported_feature,
                     "DEFAULT VALUES clause is yet not supported",
-                    stmt.expression()->region());
+                    stmt.region());
             return {};
         }
         auto source = analyze_query_expression(

diff --git a/test/mizugaki/analyzer/details/analyze_statement_insert_test.cpp b/test/mizugaki/analyzer/details/analyze_statement_insert_test.cpp
@@ -410,4 +410,14 @@ TEST_F(analyze_statement_insert_test, inconsistent_query) {
     });
 }
 
+TEST_F(analyze_statement_insert_test, default_values) {
+    options_.prefer_write_statement() = false;
+    auto table = install_table("testing");
+    invalid(sql_analyzer_code::unsupported_feature, ast::statement::insert_statement {
+            id("testing"),
+            {},
+            {}, // default values
+    });
+}
+
 } // namespace mizugaki::analyzer::details