Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): Add nullable field description to analytics table #1954

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat(analytics): Add nullable field description to analytics table #1954

merged 2 commits into from
Feb 8, 2024

Conversation

gh-PonyM
Copy link

Implements #1953

winged
winged requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, let's see what CI thinks :)

The commit doesn't look like conventional commits yet, but otherwise LGTM!

@gh-PonyM gh-PonyM force-pushed the dev_lb branch 2 times, most recently from eccd4f0 to 0e36039 Compare January 31, 2023 14:02
@gh-PonyM gh-PonyM changed the title Add nullable field description to analytics table feat(analytics): Add nullable field description to analytics table Jan 31, 2023
@winged winged enabled auto-merge January 31, 2023 14:06
auto-merge was automatically disabled January 31, 2023 15:15

Head branch was pushed to by a user without write access

@gh-PonyM
Copy link
Author

gh-PonyM commented Mar 6, 2023

Running pytest in parallel causes the issue. As you pointed out last time, running them with poetry run pytest -n 0 --reuse-db inside docker passes the tests. What should we do in this case?

winged
winged requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor cleanup required, otherwise LGTM

caluma/caluma_analytics/filters.py Show resolved Hide resolved
caluma/caluma_analytics/tests/test_table.py Outdated

snapshot.assert_match(result.data)
assert result.data["saveAnalyticsTable"]["analyticsTable"]
print(result.data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print should be removed in "production" code

@open-dynaMIX open-dynaMIX marked this pull request as draft September 22, 2023 13:02
@winged winged marked this pull request as ready for review February 8, 2024 15:58
@winged winged merged commit a2326ec into projectcaluma:main Feb 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@open-dynaMIX open-dynaMIX open-dynaMIX left review comments

@winged winged winged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gh-PonyM @winged @open-dynaMIX @MitanOmar