MultiCamera App Changes for Coverity Fix #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are made in the multicamera APP code to address the Coverity Issues One part of the issue is solved here Tracked-On: OAM-106764 Signed-off-by: pillaive <[email protected]>
shivasku82
reviewed
Mar 27, 2023
| @@ -530,11 +525,6 @@ public void run() { | |||
| System.out.println(TAG +" camera close exception"); | |||
| } | |||
|
|
|||
| if (null != imageReader) { | |||
| @@ -480,10 +479,6 @@ public void closeCamera() { | |||
| cameraDevice.close(); | |||
| cameraDevice = null; | |||
| } | |||
| if (null != imageReader) { | |||
| @@ -234,9 +235,9 @@ private String toLocalNumber(int n) { | |||
| } | |||
|
|
|||
| /** Converts the given double to a localized String version. */ | |||
| private String toLocalNumber(double n) { | |||
| /*private String toLocalNumber(double n) { | |||
There was a problem hiding this comment.
remove this commented code, if not used
| @@ -106,6 +107,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
|
|
|||
| checkPermissions(); | |||
|
|
|||
|
|
|||
| Open_Camera_ById(); | ||
| } | ||
| if (mCamera_BackView.isAvailable()) { | ||
| mCamera.textureListener.onSurfaceTextureAvailable( | ||
| mCamera_BackView.getSurfaceTexture(), mCamera_BackView.getWidth(), | ||
| mCamera_BackView.getHeight()); | ||
| } else { | ||
| mCamera_BackView.setSurfaceTextureListener(mCamera.textureListener); | ||
| if(mCamera != null) |
| @@ -25,8 +25,7 @@ | |||
| import androidx.preference.PreferenceFragment; | |||
|
|
|||
| public class SettingsActivity extends AppCompatActivity { | |||
| private String TAG = "settings"; | |||
|
|
|||
|
|
|||
| @@ -99,6 +100,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| mRoundedThumbnailView = findViewById(R.id.rounded_thumbnail_view); | |||
|
|
|||
| checkPermissions(); | |||
|
|
|||
| @@ -176,6 +177,7 @@ public static String[] generateFileDetails(int type) { | |||
| fileDetails[0] = dateFormat.format(date); | |||
| fileDetails[1] = fileDetails[0] + ".jpg"; | |||
| fileDetails[2] = "image/jpeg"; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are made in the multicamera APP code to address the Coverity Issues
One part of the issue is solved here
Tracked-On: OAM-106764