Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize egl driver prop setting logic #1983

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Optimize egl driver prop setting logic #1983

merged 1 commit into from
Aug 3, 2024

Conversation

phreer
Copy link
Contributor

@phreer phreer commented Jul 24, 2024

We want to enable hardware rendering as long as if Intel GPU is present. Previously only /proc/fb and card0 were considered.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Jul 24, 2024
feijiang1
feijiang1 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phreer
Optimize egl driver prop setting logic
9cbd1e9 
We want to enable hardware rendering as long as if Intel GPU is present.
Previously only /proc/fb and card0 were considered.

Test-done: Boot AAOS with virtio-GPU as card0.

Tracked-On: OAM-122705
Signed-off-by: Weifeng Liu <[email protected]>
feijiang1
feijiang1 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Aug 2, 2024
@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Aug 2, 2024
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

YuanjunHuang
YuanjunHuang approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@YuanjunHuang YuanjunHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Aug 2, 2024
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit a92aecb into projectceladon:master Aug 3, 2024
22 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon-merge/713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feijiang1 feijiang1 feijiang1 approved these changes

@YuanjunHuang YuanjunHuang YuanjunHuang approved these changes

@zhy1030 zhy1030 zhy1030 approved these changes

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful PR approved Valid commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phreer @sysopenci @zhy1030 @YuanjunHuang @feijiang1