Fixed the validateBufferSize issue #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feijiang1
approved these changes
Sep 15, 2023
sysopenci
reviewed
Sep 15, 2023
when we use format HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED to allocate the buffer, we get the buffer with format DRM_FORMAT_XBGR8888. The validateBufferSize will return an error because format mismatch. So we should ignore this type. Tracked-On: OAM-111885 Signed-off-by: zhangyichix <[email protected]>
chenyanxzhu
force-pushed
the
zhucx_minigbm_validatesz
branch
from
4be3cbc
to
781e9c4
Compare
feijiang1
approved these changes
Sep 18, 2023
feijiang1
approved these changes
Sep 18, 2023
sysopenci
reviewed
Sep 18, 2023
There was a problem hiding this comment.
PR integrated into 'preintegration' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/590
Done by "Jiang, Fei" [email protected]
sysopenci
reviewed
Sep 18, 2023
There was a problem hiding this comment.
PR integrated into 'premerge' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/358
Done by "Jiang, Fei" [email protected]
sysopenci
merged commit 6b8fc98
into
projectceladon:celadon/s/mr0/master
10 checks passed
sysopenci
reviewed
Sep 18, 2023
There was a problem hiding this comment.
cactus finished building and testing your changes
It was requested for merge by [email protected]
so we merge it. Thanks for your contribution.
more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we use format HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED to allocate the buffer, we get the buffer with format DRM_FORMAT_XBGR8888. The validateBufferSize will return an error because format mismatch. So we should ignore this type.
Tracked-On: OAM-110999