gralloc: unify gralloc frontends to use cros_gralloc_convert_format #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyanxzhu
force-pushed
the
zhucx_smr0_master_format
branch
2 times, most recently
from
8ebdc98
to
ac7bb7f
Compare
The previous ANDROID_VERSION is also checked against the wrong version because the fp16 and 10bit rgba formats were released in 8.0. So this change also fixes to check against api level 26 instead. BUG=b:199524294 TEST=emerge-$BOARD arc-cros-gralloc Tracked-On: OAM-112372 Change-Id: I16c1dba4901b374c5aecbc0e0f859638d08895aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3158977 Tested-by: Yiwei Zhang <[email protected]> Reviewed-by: Gurchetan Singh <[email protected]> Commit-Queue: Yiwei Zhang <[email protected]> Signed-off-by: chenyanxzhu <[email protected]>
Reordered the cases to align with actual enum value for the hal formats, and added 3 more formats support to align with gralloc4 support: 1. Y8 2. Y16 3. YCBCR_P010 BUG=b:199524294 TEST=CtsNativeHardwareTestCases TEST=gralloc4 builds in aosp Tracked-On: OAM-112372 Change-Id: I7a6743524c024d46ab2a7a6d973f431ea2721c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3160131 Tested-by: Yiwei Zhang <[email protected]> Auto-Submit: Yiwei Zhang <[email protected]> Reviewed-by: Jason Macnak <[email protected]> Reviewed-by: Gurchetan Singh <[email protected]> Commit-Queue: Yiwei Zhang <[email protected]> Signed-off-by: chenyanxzhu <[email protected]>
chenyanxzhu
force-pushed
the
zhucx_smr0_master_format
branch
2 times, most recently
from
80127b6
to
08d5c48
Compare
TianmiChen
approved these changes
Sep 25, 2023
feijiang1
approved these changes
Sep 25, 2023
sysopenci
reviewed
Sep 28, 2023
sysopenci
reviewed
Sep 28, 2023
There was a problem hiding this comment.
PR integrated into 'preintegration' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-preintegration/builds/686
Done by "Jiang, Fei" [email protected]
sysopenci
reviewed
Sep 28, 2023
There was a problem hiding this comment.
PR integrated into 'premerge' builder
More details, logs, and binaries: /absp/builders/celadon_smr0_master-premerge/builds/407
Done by "Jiang, Fei" [email protected]
sysopenci
merged commit 5187d42
into
projectceladon:celadon/s/mr0/master
12 checks passed
sysopenci
reviewed
Sep 28, 2023
There was a problem hiding this comment.
cactus finished building and testing your changes
It was requested for merge by "Jiang, Fei" [email protected]
so we merge it. Thanks for your contribution.
more details, logs, and binaries: /absp/builders/celadon_smr0_master-mergerequest/builds/402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.