[api-gateway]: Support http(s) as AppProtocol in Kubernetes svc (#6616)

* [api-gateway]: Support http, https and www-http as AppProtocol in kubernetes' service Fix #6560 Signed-off-by: Ludovic Logiou <[email protected]> * Remove legacy www-http Signed-off-by: Ludovic Logiou <[email protected]> * Fix undefined vars Signed-off-by: Ludovic Logiou <[email protected]> * Add changelog Signed-off-by: Ludovic Logiou <[email protected]> * Fix issues found by the linter Signed-off-by: Ludovic Logiou <[email protected]> * Fix format and add unit tests Signed-off-by: Ludovic Logiou <[email protected]> --------- Signed-off-by: Ludovic Logiou <[email protected]>
projectcontour · Aug 24, 2024 · 63f5e19 · 63f5e19
1 parent 20e57df
commit 63f5e19
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/changelogs/unreleased/6616-Krast76-small.md b/changelogs/unreleased/6616-Krast76-small.md
@@ -0,0 +1 @@
+Contour, support http and https as AppProtocol in k8s' services
diff --git a/internal/dag/accessors.go b/internal/dag/accessors.go
@@ -110,13 +110,17 @@ func validateExternalName(svc *core_v1.Service, enableExternalNameSvc bool) erro
 const (
 	protoK8sH2C = "kubernetes.io/h2c"
 	protoK8sWS  = "kubernetes.io/ws"
+	protoHTTPS  = "https"
+	protoHTTP   = "http"
 )
 
 func toContourProtocol(appProtocol string) (string, bool) {
 	proto, ok := map[string]string{
 		// *NOTE: for gateway-api: the websocket is enabled by default
 		protoK8sWS:  "",
 		protoK8sH2C: "h2c",
+		protoHTTP:   "",
+		protoHTTPS:  "tls",
 	}[appProtocol]
 	return proto, ok
 }

diff --git a/internal/dag/accessors_test.go b/internal/dag/accessors_test.go
@@ -127,6 +127,18 @@ func TestBuilderLookupService(t *testing.T) {
 					AppProtocol: ptr.To("kubernetes.io/wss"),
 					Port:        8444,
 				},
+				{
+					Name:        "iana-https",
+					Protocol:    "TCP",
+					AppProtocol: ptr.To("https"),
+					Port:        8445,
+				},
+				{
+					Name:        "iana-http",
+					Protocol:    "TCP",
+					AppProtocol: ptr.To("http"),
+					Port:        8446,
+				},
 			},
 		},
 	}
@@ -218,6 +230,16 @@ func TestBuilderLookupService(t *testing.T) {
 			port:           8444,
 			want:           appProtcolService(appProtoService, "", 1),
 		},
+		"lookup service by port number with supported IANA app protocol: https": {
+			NamespacedName: types.NamespacedName{Name: appProtoService.Name, Namespace: appProtoService.Namespace},
+			port:           8445,
+			want:           appProtcolService(appProtoService, "tls", 2),
+		},
+		"lookup service by port number with supported IANA app protocol: http": {
+			NamespacedName: types.NamespacedName{Name: appProtoService.Name, Namespace: appProtoService.Namespace},
+			port:           8446,
+			want:           appProtcolService(appProtoService, "", 3),
+		},
 	}
 
 	for name, tc := range tests {