Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for General RateLimit Policy #5363
Add support for General RateLimit Policy #5363
Changes from 26 commits
a2dac6f
b9f9d62
6556fba
29cc715
735f8f2
962665a
e161d16
eef2f8a
de0319e
ff8ac04
5254299
0b03e57
8f1c4d9
5b66310
fbf98dc
04a01ef
e5e74a2
03badbe
04ef7b6
e3943df
c853958
5618e59
530fef3
cfba9e3
55ad4c8
4e39815
b712271
37d41de
43c1205
6f22159
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 519 in cmd/contour/serve.go
Codecov / codecov/patch
cmd/contour/serve.go#L519
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref #5458 this is another instance where we should probably apply this to at least the Ingress processor as well. I'm OK logging a follow-up issue since we don't currently support rate limiting in any way on Ingress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do that, thanks for pointing this out!