Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.23.2 #6718

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bump Go to 1.23.2 #6718

wants to merge 2 commits into from

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Oct 19, 2024 •
edited
Loading

This pull request includes following changes

The PR also includes following lint fixes:

Remove tools from build tags when running lint to avoid error

tools.go:7:2: import "github.com/ahmetb/gen-crd-api-reference-docs" is a program, not an importable package (typecheck)
        _ "github.com/ahmetb/gen-crd-api-reference-docs"

@tsaarni tsaarni requested a review from a team as a code owner October 19, 2024 09:32
@tsaarni tsaarni requested review from skriss and sunjayBhatia and removed request for a team October 19, 2024 09:32
@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team October 19, 2024 09:32
@tsaarni
Bump Go to 1.23.2
b194735 
Signed-off-by: Tero Saarni <[email protected]>
@tsaarni tsaarni added the release-note/small A small change that needs one line of explanation in the release notes. label Oct 19, 2024
@tsaarni tsaarni marked this pull request as draft October 19, 2024 10:10
@tsaarni
Copy link
Member Author

tsaarni commented Oct 19, 2024

Marking as draft for now. There are gosec "G115: integer overflow conversion" errors, as well as some other lint errors that should be easier to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss Awaiting requested review from skriss skriss is a code owner automatically assigned from projectcontour/maintainers

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia sunjayBhatia is a code owner automatically assigned from projectcontour/maintainers

@izturn izturn Awaiting requested review from izturn izturn was automatically assigned from projectcontour/contour-reviewers

@clayton-gonsalves clayton-gonsalves Awaiting requested review from clayton-gonsalves clayton-gonsalves was automatically assigned from projectcontour/contour-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsaarni