Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadConfig S3 based on AWS_PROFILE ~/.aws/credentials #5680

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

alban-stourbe-wmx
Copy link
Contributor

@alban-stourbe-wmx alban-stourbe-wmx commented Oct 1, 2024

Proposed changes

To retrieve a S3 bucket based on a loacConfid, i have added a feature allowing to use AWS_PROFILE from ~/.aws/credentials file.

The aim is to be able to use the profile option from aws cli like
aws s3 ls --profile my-profile

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-assign auto-assign bot requested a review from dogancanbakir October 1, 2024 09:47
@GeorginaReeder
Copy link

Thanks for your contribution @alban-stourbe-wmx ! :)

@dogancanbakir
Copy link
Member

Could you please merge the dev branch into this one to verify if all tests are passing? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants