Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Subfinder SDK Usability #1466

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mielverkerken
Copy link

Improved Subfinder SDK Usability

The current subfinder Go module has limited functionality as an SDK. While it allows configuring the runner and performing enumerations, obtaining results requires passing through writers and parsing the output again, which is inefficient for programmatic use.

This pull request introduces a change to make the subfinder module more SDK-friendly by directly returning the sourceMap. The sourceMap contains the enumerated subdomains along with the sources that identified them, eliminating the need to reprocess the output.

Key Changes

  • Modified the enumeration logic to return the sourceMap as a result.
  • Kept changes minimal to minimize the impact on other parts of the codebase.
  • Modified example code to use subfinder Go module to use the sourceMap.

@mielverkerken mielverkerken changed the title Make subfinder go module more useful Improved Subfinder SDK Usability Dec 6, 2024
v2/examples/main.go Dismissed Show dismissed Hide dismissed
@GeorginaReeder
Copy link

Thanks for your contribution @mielverkerken , we appreciate it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants