Removing extra shell command; Use bash builtin for extracting a subst…

…ring (#221) Removing extra shell command; Use bash builtin for extracting a substring Signed-off-by: Mykhailo Kravchuk <[email protected]>
prometheus-community · Oct 23, 2024 · 6e26d97 · 6e26d97
1 parent 6b36c81
commit 6e26d97
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/smartmon.sh b/smartmon.sh
@@ -167,12 +167,13 @@ format_output() {
     awk -F'{' "${output_format_awk}"
 }
 
-smartctl_version="$(/usr/sbin/smartctl -V | head -n1 | awk '$1 == "smartctl" {print $2}')"
+smartctl_version="$(/usr/sbin/smartctl -V | awk 'NR==1 && $1 == "smartctl" {print $2}')"
 
 echo "smartctl_version{version=\"${smartctl_version}\"} 1" | format_output
 
-if [[ "$(expr "${smartctl_version}" : '\([0-9]*\)\..*')" -lt 6 ]]; then
-  exit
+# Exit if "smartctl" version is lower 6
+if [[ ${smartctl_version%.*} -lt 6 ]]; then
+  exit 0
 fi
 
 device_list="$(/usr/sbin/smartctl --scan-open | awk '/^\/dev/{print $1 "|" $3}')"