-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #379 from prometheus/fabxc-inhibit-fix
inhibit: reduce O(n^2) complexity problem
- Loading branch information
Showing
3 changed files
with
284 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,168 @@ | ||
// Copyright 2016 Prometheus Team | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package main | ||
|
||
import ( | ||
"reflect" | ||
"testing" | ||
"time" | ||
|
||
"github.com/kylelemons/godebug/pretty" | ||
"github.com/prometheus/alertmanager/types" | ||
"github.com/prometheus/common/model" | ||
) | ||
|
||
func TestInhibitRuleHasEqual(t *testing.T) { | ||
now := time.Now() | ||
cases := []struct { | ||
initial map[model.Fingerprint]*types.Alert | ||
equal model.LabelNames | ||
input model.LabelSet | ||
result bool | ||
}{ | ||
{ | ||
// No source alerts at all. | ||
initial: map[model.Fingerprint]*types.Alert{}, | ||
input: model.LabelSet{"a": "b"}, | ||
result: false, | ||
}, | ||
{ | ||
// No equal labels, any source alerts satisfies the requirement. | ||
initial: map[model.Fingerprint]*types.Alert{1: &types.Alert{}}, | ||
input: model.LabelSet{"a": "b"}, | ||
result: true, | ||
}, | ||
{ | ||
// Matching but already resolved. | ||
initial: map[model.Fingerprint]*types.Alert{ | ||
1: &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "b", "b": "f"}, | ||
StartsAt: now.Add(-time.Minute), | ||
EndsAt: now.Add(-time.Second), | ||
}, | ||
}, | ||
2: &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "b", "b": "c"}, | ||
StartsAt: now.Add(-time.Minute), | ||
EndsAt: now.Add(-time.Second), | ||
}, | ||
}, | ||
}, | ||
equal: model.LabelNames{"a", "b"}, | ||
input: model.LabelSet{"a": "b", "b": "c"}, | ||
result: false, | ||
}, | ||
{ | ||
// Matching but already resolved. | ||
initial: map[model.Fingerprint]*types.Alert{ | ||
1: &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "b", "c": "d"}, | ||
StartsAt: now.Add(-time.Minute), | ||
EndsAt: now.Add(-time.Second), | ||
}, | ||
}, | ||
2: &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "b", "c": "f"}, | ||
StartsAt: now.Add(-time.Minute), | ||
EndsAt: now.Add(-time.Second), | ||
}, | ||
}, | ||
}, | ||
equal: model.LabelNames{"a"}, | ||
input: model.LabelSet{"a": "b"}, | ||
result: false, | ||
}, | ||
{ | ||
// Equal label does not match. | ||
initial: map[model.Fingerprint]*types.Alert{ | ||
1: &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "c", "c": "d"}, | ||
StartsAt: now.Add(-time.Minute), | ||
EndsAt: now.Add(-time.Second), | ||
}, | ||
}, | ||
2: &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "c", "c": "f"}, | ||
StartsAt: now.Add(-time.Minute), | ||
EndsAt: now.Add(-time.Second), | ||
}, | ||
}, | ||
}, | ||
equal: model.LabelNames{"a"}, | ||
input: model.LabelSet{"a": "b"}, | ||
result: false, | ||
}, | ||
} | ||
|
||
for _, c := range cases { | ||
r := &InhibitRule{ | ||
Equal: map[model.LabelName]struct{}{}, | ||
scache: map[model.Fingerprint]*types.Alert{}, | ||
} | ||
for _, ln := range c.equal { | ||
r.Equal[ln] = struct{}{} | ||
} | ||
for k, v := range c.initial { | ||
r.scache[k] = v | ||
} | ||
|
||
if have := r.hasEqual(c.input); have != c.result { | ||
t.Errorf("Unexpected result %q, expected %q", have, c.result) | ||
} | ||
if !reflect.DeepEqual(r.scache, c.initial) { | ||
t.Errorf("Cache state unexpectedly changed") | ||
t.Errorf(pretty.Compare(r.scache, c.initial)) | ||
} | ||
} | ||
} | ||
|
||
func TestInhibitRuleGC(t *testing.T) { | ||
// TODO(fabxc): add now() injection function to Resolved() to remove | ||
// dependency on machine time in this test. | ||
now := time.Now() | ||
newAlert := func(start, end time.Duration) *types.Alert { | ||
return &types.Alert{ | ||
Alert: model.Alert{ | ||
Labels: model.LabelSet{"a": "b"}, | ||
StartsAt: now.Add(start * time.Minute), | ||
EndsAt: now.Add(end * time.Minute), | ||
}, | ||
} | ||
} | ||
|
||
before := map[model.Fingerprint]*types.Alert{ | ||
0: newAlert(-10, -5), | ||
1: newAlert(10, 20), | ||
2: newAlert(-10, 10), | ||
3: newAlert(-10, -1), | ||
} | ||
after := map[model.Fingerprint]*types.Alert{ | ||
1: newAlert(10, 20), | ||
2: newAlert(-10, 10), | ||
} | ||
|
||
r := &InhibitRule{scache: before} | ||
r.gc() | ||
|
||
if !reflect.DeepEqual(r.scache, after) { | ||
t.Errorf("Unexpected cache state after GC") | ||
t.Errorf(pretty.Compare(r.scache, after)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters