-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: cross build in ci and fix publish #3533
Conversation
c1c0e4c
to
e83aa77
Compare
Signed-off-by: Jan Fajerski <[email protected]>
e83aa77
to
8ba89e1
Compare
08b7b11
to
ce0ead4
Compare
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: prometheus/promci@v0.0.2 | ||
- uses: prometheus/promci@3cb0c3871f223bd5ce1226995bd52ffb314798b6 # v0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we downgrading here? That's wrong with the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually an upgrade from v0.0.2
to v0.1.0
:) The pinning to a sha I copied from Prometheus, seems like good practice and I intend to do that for the other instances too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 I need to learn to read a bit better - agreed, pinning of versions saves us from unexpected failures.
.github/workflows/publish.yml
Outdated
docker_hub_login: ${{ secrets.docker_hub_login }} | ||
docker_hub_password: ${{ secrets.docker_hub_password }} | ||
quay_io_organization: ${{ secrets.quay_io_organization }} | ||
quay_io_login: ${{ secrets.quay_io_login }} | ||
quay_io_password: ${{ secrets.quay_io_password }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these secrets are defined. At which point would be ready to test them? How did you approach this in Prometheus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm looking into that, not sure myself at this point. In my clone I defined those secrets but it still fails, there is something I don't understand with multi arch builds.
If those secrets don't exist the publish action is just a no-op. so we can leave this for now and once we understand what's going on, defining the secrets is all that is needed to publish from the action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they should be defined at the prometheus org level
Looking at the current failures, I also see:
|
.github/workflows/publish.yml
Outdated
branches: | ||
- main | ||
# branches: | ||
# - main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just temporary to tigger the action on a PR push. I'll drop all DEBUG
commits before this merges.
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
thread: [ 0, 1, 2 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This complexity is not needed for alertmanager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took this from the circleci build job thinking its a reasonable check before merge. Happy to drop if it isn't needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also #3530 wants to extend this.
.github/workflows/publish.yml
Outdated
- uses: ./.github/promci/actions/publish_main | ||
with: | ||
docker_hub_login: ${{ secrets.docker_hub_login }} | ||
docker_hub_password: ${{ secrets.docker_hub_password }} | ||
quay_io_organization: ${{ secrets.quay_io_organization }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roidelapluie is right these all are defined at an org-level except this one - why do we need this one again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again a debug commit to change the org to my quay org.
Any chance we could speed this one up @jan--f - I have constant failures on main and would love to avoid those. Thanks! |
@gotjosh sorry, let me drop the debug commits to reduce noise. |
ce0ead4
to
b636b5d
Compare
Signed-off-by: Jan Fajerski <[email protected]>
Ok I added the build step before the release action as well. |
* actions: cross build in ci and fix publish Signed-off-by: Jan Fajerski <[email protected]> * actions: build before release publishing Signed-off-by: Jan Fajerski <[email protected]> --------- Signed-off-by: Jan Fajerski <[email protected]>
This add
TODO: add a release action and discuss and add appropriate trigger filters for release and publish.