-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direction to Scroll #33
base: master
Are you sure you want to change the base?
Conversation
@@ -34,6 +34,7 @@ static void PBSwizzleMethod(Class c, SEL original, SEL alternate) { | |||
|
|||
// Keys for values in associated dictionary | |||
static const void *kPBInfiniteScrollStateKey = &kPBInfiniteScrollStateKey; | |||
static const void *kPBInfiniteScrollDirectionKey = &kPBInfiniteScrollDirectionKey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why it cannot reside within pb_infiniteScrollState
?
Hi @bercik0291, I just pulled your fork and it works very well! Apart from couple of minor issues, great work! I'll see if I can find some time over weekend to refine your PR. Thank you! |
|
||
/** | ||
* Finish infinite scroll animations | ||
* | ||
* You must call this method from your infinite scroll handler to finish all | ||
* animations properly and reset infinite scroll state | ||
*/ | ||
- (void)finishInfiniteScroll; | ||
- (void)finishInfiniteScroll:(BOOL)animated; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to add DEPRECATED
attribute and keep the method around for a while so others could adjust.
@pronebird Ok, thanks for review, I will fix everything during this weekend |
The PR unfortunately does not work with |
Any updates on this? @bercik0291 @pronebird |
449ebbc
to
fcda341
Compare
Hi there, Any update on this? |
I'll post my workaround as mentioned in #30 here as well:
|
@Flitskikker How does it work without inverting your data? I think that messages supposed to be in reversed order after these operations. Or am I wrong? |
@Kacper20 It works by first mirroring the whole UITableView vertically, and then mirroring the individual cells vertically. That way, the order is reversed without altering the data source. Also the scroll direction is reversed, including the infinite scrolling. The activity indicator is also mirrored, so I create a new already mirrored activity indicator, so that the resulting activity loader will look normal (actually it's mirrored twice). Why mirror vertically instead of rotating 180 degrees? Then the swipe actions still work normally (from the right hand side)! |
Thanks for explanation @Flitskikker. I was meaning, that to maintain old positioning(oldest message "A" first on the list) you'd have to reverse your data source too.(now you have C, B, A). Cheers, |
@Flitskikker @Kacper20 haven't had time to revisit this. This PR has to be refined and merged with existing master. |
How to use it? is it merged in current commit? |
Hey @pronebird @bercik0291, Could you please take a look at this and merge it when ready. Or any update on when to expect it? Thanks in advance! |
@sasojadrovski there are issues with this PR and I left comments long ago but I don't think there's been any progress on this since then. :/ |
add ability to choose direction of infinity scroll (top or bottom).