EV-2500: fix-sharepoint-online-apostrophes-in-file-names

[klondikemarlen]

EV-2500

Overview

Upload a file on Edge to SharePoint Online with an apostrophe in the filename.
The routing will enter a broken state and 500 whenever sync is run.

Solution

🪲 Hopefully fix apostrophes woes.
Fix from Plaristote#39

Testing Instructions

See https://github.com/proofgov/proofgov/wiki/Development:-SharePoint-Docs-Snippets for setting up a SharePoint environment

1. Checkout https://github.com/proofgov/proofgov/pull/2246 and do a dev bash -> bundle install

Will need to create a Personal Access Token on github and use in place of password for https connection. See https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token

2. Do a ENABLE_SSL=true dev restart
3. Go to a SharePoint Online backed routing and upload a previewable file with an apostrophe in the file name.
4. Click on the link and make sure it loads correctly
5. Go to a SharePoint Online backed routing and upload a non-previewable file with an apostrophe in the file name.
6. Click on the link and make sure it loads correctly
7. Check that upload sync works (click the sync button).
8. Repeat the process for a SharePoint 2013 backed routing. You will need to create a new routing for this.

Pre-Merge Checklist

• The work here reflects the user stories in the JIRA ticket(s) listed at the top of this pull request
• This pull request has been referenced via URL in the JIRA ticket(s) listed
• I have performed a self-review of the code I have written here
• I have done end-to-end QA testing of sections of the application I have altered
• My changes generate no new warnings / errors in the console

Special Pre- or Post-Deployment Instructions

Will require updating and republishing the proofgov/sharepoint-api gem.

Reminder that deploy instructions are here

[jaemo]

👍🏼

[jgigault-pa]

👍