Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasync): add datasync service and its check #5444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdriiiPRodri
Copy link

Context

To cover the checks for the DataSync service, in this PR we have added that service and have also included the only available check at this moment: DataSync Controls.

Description

This PR adds:

  • DataSync service.
  • DataSync client.
  • Current checks.
  • Unittest for both, service and checks.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AdriiiPRodri AdriiiPRodri added the provider/aws Issues/PRs related with the AWS provider label Oct 17, 2024
@AdriiiPRodri AdriiiPRodri requested review from sergargar and a team October 17, 2024 08:53
@AdriiiPRodri AdriiiPRodri self-assigned this Oct 17, 2024
@AdriiiPRodri AdriiiPRodri requested a review from a team as a code owner October 17, 2024 08:53
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (45c32ab) to head (c494deb).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5444      +/-   ##
==========================================
+ Coverage   89.21%   89.33%   +0.11%     
==========================================
  Files        1044     1052       +8     
  Lines       32225    32651     +426     
==========================================
+ Hits        28750    29169     +419     
- Misses       3475     3482       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdriiiPRodri AdriiiPRodri force-pushed the PRWLR-4804-DataSync-tasks-should-have-logging-enabled branch from ca39f67 to c1fea2a Compare October 17, 2024 11:03
@AdriiiPRodri AdriiiPRodri force-pushed the PRWLR-4804-DataSync-tasks-should-have-logging-enabled branch from c1fea2a to c494deb Compare October 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant