refactor(finding): Add metadata object #5447
Open
+539
−529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
github_actions
jfagoagas
commented
Oct 17, 2024
| check_id: str | ||
| check_title: str | ||
| check_type: str | ||
| uid: str |
There was a problem hiding this comment.
Warning
Changed finding_uid to uid
jfagoagas
commented
Oct 17, 2024
| finding_dict["RESOURCE_TAGS"] = unroll_dict(finding.resource_tags) | ||
| finding_dict["COMPLIANCE"] = unroll_dict( | ||
| finding.compliance, separator=": " | ||
| finding_dict = {} |
There was a problem hiding this comment.
Warning
This is needed because now the Finding object does not mimic the CSV output format.
jfagoagas
commented
Oct 17, 2024
| @@ -173,7 +157,7 @@ def generate_output( | |||
| check_output.project_id | |||
| ].organization.id | |||
| # TODO: for now is None since we don't retrieve that data | |||
| output_data["account_organization"] = provider.projects[ | |||
| output_data["account_organization_name"] = provider.projects[ | |||
There was a problem hiding this comment.
🐛 because account_organization was not a valid field.
jfagoagas
commented
Oct 17, 2024
Comment on lines
+173
to
+175
| "categories": ["test-category"], | ||
| "depends_on": ["test-dependency"], | ||
| "related_to": ["test-related-to"], |
There was a problem hiding this comment.
This was wrong because these fields must be a list.
|
You can check the documentation for this PR here -> Prowler Documentation |
|
You can check the documentation for this PR here -> Prowler Documentation |
|
You can check the documentation for this PR here -> Prowler Documentation |
github-actions
bot
added
provider/aws
|
You can check the documentation for this PR here -> Prowler Documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
finding_uidtouidmetadatatoFindingwith aget_metadatamethod.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.