Add GET /eth/v2/beacon/pool/attester_slashings
#14479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
changed the title
/eth/v2/beacon/pool/attester_slashings/eth/v2/beacon/pool/attester_slashings
james-prysm
reviewed
Oct 3, 2024
james-prysm
reviewed
Oct 9, 2024
| ss := make([]*eth.AttesterSlashingElectra, len(sourceSlashings)) | ||
| for i, slashing := range sourceSlashings { | ||
| a, ok := slashing.(*eth.AttesterSlashingElectra) | ||
| if ok { |
There was a problem hiding this comment.
you could do the reverse here and avoid the else
james-prysm
reviewed
Oct 9, 2024
james-prysm
reviewed
Oct 9, 2024
rkapka
requested changes
Oct 10, 2024
| @@ -172,6 +172,11 @@ type GetAttesterSlashingsResponse struct { | |||
| Data []*AttesterSlashing `json:"data"` | |||
| } | |||
|
|
|||
| type GetAttesterSlashingsV2Response struct { | |||
| Version string `json:"version"` | |||
| Data []json.RawMessage `json:"data"` // Accepts both `[]*AttesterSlashing` and `[]*AttesterSlashingElectra` types | |||
There was a problem hiding this comment.
Single json.RawMessage will make the code more compact
| } | ||
| v := version.String(headState.Version()) |
There was a problem hiding this comment.
The version should be based on the version of the slashing, not the state. This is because (1) the only possible slashing versions are Phase0 and Electra, and (2) the state here can be after a fork with the slashing being before the fork.
rkapka
reviewed
Oct 10, 2024
| @@ -172,6 +172,11 @@ type GetAttesterSlashingsResponse struct { | |||
| Data []*AttesterSlashing `json:"data"` | |||
| } | |||
|
|
|||
| type GetAttesterSlashingsV2Response struct { | |||
There was a problem hiding this comment.
This is a different approach than what you did for https://github.com/prysmaticlabs/prysm/pull/14481/files#diff-b7de0123b995294eb1e799afb080f62c9a4a08195f9ed1f387a9071922b1ec97. Can you do the same here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Beacon API Electra alignment, add missing endpoint for
/eth/v2/beacon/pool/attester_slashings.As described in the spec https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getPoolAttesterSlashingsV2
Which issues(s) does this PR fix?
Part of #14476
Other notes for review
Acknowledgements