-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution API Electra: requests as a sidecar #14492
base: develop
Are you sure you want to change the base?
Conversation
proto/engine/v1/electra.proto
Outdated
} | ||
|
||
// ExecutionEnvelopeElectra is a container that builds on Payload V4 and includes execution requests sidecar needed post Electra | ||
message ExecutionEnvelopeElectra { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I call it something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts with epbs, i should rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think naming it mentioning electra is self explanatory to me like we have simple ExecutionPayloadEnvelope so in my views its ok to keep this naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to change this, talked to potuz
} | ||
pr := common.Hash(blk.Block().ParentRoot()) | ||
// TODO: get encoded hash for execution requests | ||
executionRequestsHash := &common.Hash{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we don't want to do this
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements ethereum/execution-apis#591, ethereum/execution-apis#597
engine_newPayloadV4
andengine_getPayloadV4
related prs Move
execution_requests
afterparent_beacon_block_root
ethereum/consensus-specs#3967, Pass execution requests to Engine API as a list of bytes ethereum/consensus-specs#3969Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements