Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode DPNS data contract in the code #9

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

pshenmic
Copy link
Owner

Issue

DPNS data contract schema previously was being loaded from the filesystem (as it was during development), and I forgot to to put in inside the build. Users who tried to use the binary from the releases had to have a local dpns data contract schema file, or they encounter a error:

thread 'main' panicked at src/commands/register_dpns_name.rs:86:80:
Unable to read file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace 

In this PR I moved schema straight in the code so it is shipped with the binaries

Things done

  • Created a constants module with raw DPNS data contract schema

@pshenmic pshenmic self-assigned this Oct 20, 2024
@pshenmic pshenmic merged commit 22c65dd into master Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant