Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster find_volume with global scene #44

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Faster find_volume with global scene #44

merged 7 commits into from
Dec 7, 2023

Conversation

pshriwise
Copy link
Owner

This implements find_volume in a faster way. Needed to add a new RayFireType that keeps the triangle normals from being adjusted according to the surface sense in the triangle intersector to do so.

@ebknudsen
Copy link
Collaborator

One thing I don't understand in the find_volume function. If the point to be checked happens to be outside all volumes on an intersection trajectory with volume j, then would that not lead to a return of volume j, even though the point is outside?
From the logic of lines 759-770 I mean. Or maybe I've misunderstood something (likely)

@pshriwise
Copy link
Owner Author

One thing I don't understand in the find_volume function. If the point to be checked happens to be outside all volumes on an intersection trajectory with volume j, then would that not lead to a return of volume j, even though the point is outside?
From the logic of lines 759-770 I mean. Or maybe I've misunderstood something (likely)

This point would be considered to be in the implicit complement, which may or may not be valid depending on the use-case of the DAGMC model. This is definitely something I'd like to discuss in the DAGMC meeting tomorrow morning.

@ebknudsen
Copy link
Collaborator

ebknudsen commented Aug 30, 2023 via email

@pshriwise
Copy link
Owner Author

@ebknudsen I'm going to try to get a new release out soon. When you have a chance, can you let me know if there are any outstanding issues you'd like me to take a look at here?

@ebknudsen
Copy link
Collaborator

@pshriwise - I don't have any outstanding issues right now. So I think you can go ahead and trigger the build scripts so to speak.

@pshriwise
Copy link
Owner Author

@pshriwise - I don't have any outstanding issues right now. So I think you can go ahead and trigger the build scripts so to speak.

Awesome. Thanks!

@pshriwise pshriwise merged commit f60b111 into develop Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants