Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is required after improving
exit
flow inpspsdk
pspdev/pspsdk#222
The reason why now is this required is because
_exit
definition has been moved tocrt0
andcrt0_prx
files.In theory, this is totally right, however, the
bootstrap
module being used here, is quite messy.When generating a
prx
if you define the functionmodule_start
the wholectr0_prx
will be skipped, then the boostrap module uses some functions fromnewlib
, and these functions from newlib ends needing_exit
, which wasn't included becausecrt0_prx
was skipped.I'm not sure if we should move
_end
out of thecrt0
andcrt0_prx
, I don't think so, however, I'm pretty sure that the issue we are suffering is an edge case, so I think we shouldn't worry that much for now...Cheers.