Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sysroot and native-system-header-dir #37

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

fjtrujy
Copy link
Member

@fjtrujy fjtrujy commented Jun 3, 2024

Description

I was trying to compile https://github.com/google/googletest for PSP and I was facing some errors when finding the MAX_PATH macro.

Then I faced that the generated header files for GCC step 2 they weren't generated properly.
Afther some days of investigation I have been able to find out where the issue was, we missed the usage of sysroot and native-system-header-dir

I have made also some clean up in the scripts:

  • Remove all the exit 1 as we have defined the onerr function.
  • Reduce GCC phase 1 compilation
  • Other minor changes.

Once merged I will add googletest as dependency in psp-packages in this way we could at least notice in the future similar issues.

This PR deprecates the previous one #36.

Cheers.

@fjtrujy fjtrujy changed the title Use sysroot and native-system-header-dir Use sysroot and native-system-header-dir Jun 3, 2024
@fjtrujy fjtrujy requested a review from davidgfnet June 3, 2024 14:13
@fjtrujy
Copy link
Member Author

fjtrujy commented Jun 3, 2024

@davidgfnet please double-check that everything is working as expected.
And feel free to add more info if you think it is relevant.

Cheers.

@davidgfnet
Copy link
Contributor

Works as expected for me!

@davidgfnet davidgfnet merged commit 5ad0c82 into pspdev:main Jun 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants